Skip to content

Telink b91 tlsr9518adk serial gpio #35533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 21, 2021
Merged

Telink b91 tlsr9518adk serial gpio #35533

merged 8 commits into from
Jul 21, 2021

Conversation

@yurvyn
Copy link

@yurvyn yurvyn commented May 21, 2021

Basic support for Telink B91 SoC and TLSR9518ADK board:

  • PinMux Driver
  • Serial Driver
  • GPIO Driver

@github-actions
Copy link

github-actions bot commented May 21, 2021 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_telink N/A zephyrproject-rtos/hal_telink@ffcfd62 (main) N/A

Note: This message is automatically posted and updated by the Manifest GitHub Action.

galak
galak reviewed May 21, 2021
View reviewed changes
galak
galak reviewed May 21, 2021
View reviewed changes
galak
galak reviewed May 21, 2021
View reviewed changes
galak
galak reviewed May 21, 2021
View reviewed changes
galak
galak reviewed May 21, 2021
View reviewed changes
@galak galak requested a review from katsuster May 21, 2021 11:29
@yurvyn yurvyn mentioned this pull request May 21, 2021
Closed
@zephyrbot zephyrbot added area: UART Universal Asynchronous Receiver-Transmitter area: Pinmux area: GPIO area: RISCV RISCV Architecture (32-bit & 64-bit) labels May 21, 2021
@yurvyn
Copy link
Author

yurvyn commented May 21, 2021

Hi all,
Next week I will not have access to the internet and I will not be able to response messages.
Will come back on May, 31.

@yurvyn yurvyn requested a review from MaureenHelm as a code owner June 30, 2021 14:23
@github-actions github-actions bot added the area: API Changes to public APIs label Jun 30, 2021
@yurvyn yurvyn requested review from galak and stephanosio June 30, 2021 14:44
@yurvyn
Copy link
Author

yurvyn commented Jun 30, 2021

@galak, @stephanosio, @mbolivar-nordic

All your comments are fixed.
Please review.

@yurvyn
Copy link
Author

yurvyn commented Jun 30, 2021

@galak, @stephanosio, @mbolivar-nordic

West setup check fails with ERROR: update failed for project tinycrypt.
Looks like it is not related to my changes.

Should I do something with it?

@yurvyn
Copy link
Author

yurvyn commented Jul 5, 2021

@galak, @stephanosio, @mbolivar-nordic

All your comments are fixed.
Please review.

@galak, @stephanosio, @mbolivar-nordic

West setup check fails with ERROR: update failed for project tinycrypt.
Looks like it is not related to my changes.

Should I do something with it?

@galak, @stephanosio, @mbolivar-nordic

In case if you are OK with my fixes and if you do not have new comments, please approve the review.

@yurvyn
Copy link
Author

yurvyn commented Jul 6, 2021

@galak, @stephanosio, @mbolivar-nordic

I already have a list of other drivers/subsystems which are waiting for PR, such as: IEEF802154/OpenThread, PWM, Flash, Entropy, SPI, I2C etc. Pull requests for such divers can be created in parallel, but they all are blocked by this basic PR.

Could you please speed up the review?

@yurvyn
Copy link
Author

yurvyn commented Jul 9, 2021

Hello @galak, @stephanosio, @mbolivar-nordic

Looks like you have reviewed all files.
From my side all comments are fixed, CI checks are passed.

Could you please approve the PR?

stephanosio
stephanosio previously requested changes Jul 12, 2021
View reviewed changes
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments

Yuriy Vynnychek added 5 commits July 12, 2021 16:16
soc: riscv: telink_b91: new Telink B91 (TLSR9) SoC system
ac35a62 
A new RISC-V platform SoC for Telink B91 (TLSR9).

Signed-off-by: Yuriy Vynnychek <[email protected]>
include: dt-bindings: b91_pinctrl: add pinctrl bindings for B91
15ee50d 
Added DT pinctrl bindings for new Telink B91 SoC.

Signed-off-by: Yuriy Vynnychek <[email protected]>
dts: riscv: add basic dts support for new Telink B91 platform
69a0c91 
CPU, Power, GPIO, Serial and Pinctrl dtsi support for new
Telink B91 RISC-V platform.

Signed-off-by: Yuriy Vynnychek <[email protected]>
modules: hal_telink: introduce new HAL Telink module
008dda9 
This commit introduce new HAL Telink module used by
new Telink B91 RISC-V platform drivers.

Signed-off-by: Yuriy Vynnychek <[email protected]>
boards: riscv: tlsr9518adk80d: new Telink B91 board support
f36b1fc 
New Telink RISC-V B91 Generic Starter Kit board support.

Signed-off-by: Yuriy Vynnychek <[email protected]>
@yurvyn yurvyn requested a review from stephanosio July 13, 2021 07:09
@yurvyn
Copy link
Author

yurvyn commented Jul 13, 2021

@galak, @stephanosio, @mbolivar-nordic

All comments are fixed, CI checks are passed.
Please approve the PR.

@mbolivar-nordic
Copy link
Contributor

mbolivar-nordic commented Jul 15, 2021

All comments are fixed, CI checks are passed.

One of my comments was marked resolved but I'm not sure of the response, so I unresolved it.

Yuriy Vynnychek added 3 commits July 16, 2021 12:38
drivers: gpio: introduce new Telink B91 GPIO driver
bd83299 
GPIO driver basic support for new Telink B91 platform.

Signed-off-by: Yuriy Vynnychek <[email protected]>
drivers: pinmux: introduce new Telink B91 Pinmux driver
aeca14b 
Pinmux driver basic support for new Telink B91 platform.

Signed-off-by: Yuriy Vynnychek <[email protected]>
drivers: serial: introduce new Telink B91 Serial driver
9a4a470 
Serial driver basic support for new Telink B91 platform.

Signed-off-by: Yuriy Vynnychek <[email protected]>
@yurvyn
Copy link
Author

yurvyn commented Jul 16, 2021

One of my comments was marked resolved but I'm not sure of the response, so I unresolved it.

@mbolivar-nordic,

Please check the fix.
If everything is OK and and if you are done with the review, cloud you please approve the PR?

mbolivar-nordic
mbolivar-nordic approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience and the IRQ change! My comments are addressed.

@yurvyn
Copy link
Author

yurvyn commented Jul 20, 2021

Hello @stephanosio,

The last one change request is left which is blocking merging.

Could you please check my fixes and mark them as resolved?

@stephanosio stephanosio dismissed their stale review July 20, 2021 14:06

outdated

stephanosio
stephanosio reviewed Jul 20, 2021
View reviewed changes
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had time to go through the entire series again, but the previous comments seem to have been addressed and it looks ok overall.

@yurvyn
Copy link
Author

yurvyn commented Jul 20, 2021

@carlescufi, @stephanosio, @galak, @ioannisg, @mbolivar-nordic

Could anyone please merge the PR?

@cfriedt cfriedt merged commit 15818a8 into zephyrproject-rtos:main Jul 21, 2021
@yurvyn yurvyn deleted the telink_b91_tlsr9518adk_serial_gpio branch August 16, 2021 14:30
@ycsin ycsin mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephanosio stephanosio stephanosio left review comments

@carlescufi carlescufi carlescufi approved these changes

@kgugala kgugala Awaiting requested review from kgugala

@mnkp mnkp Awaiting requested review from mnkp

@nashif nashif Awaiting requested review from nashif

@pgielda pgielda Awaiting requested review from pgielda

@katsuster katsuster Awaiting requested review from katsuster

@dcpleung dcpleung Awaiting requested review from dcpleung

@mgielda mgielda Awaiting requested review from mgielda

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@galak galak Awaiting requested review from galak

+2 more reviewers

@cwshu cwshu cwshu left review comments

@mbolivar-nordic mbolivar-nordic mbolivar-nordic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mnkp mnkp

Labels

area: API Changes to public APIs area: Boards area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree area: Documentation area: GPIO area: Modules area: Pinmux area: RISCV RISCV Architecture (32-bit & 64-bit) area: UART Universal Asynchronous Receiver-Transmitter manifest manifest-hal_telink

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@yurvyn @carlescufi @ioannisg @mbolivar-nordic @cwshu @stephanosio @galak @cfriedt @zephyrbot @mnkp