Skip to content

Conversation

@str4t0m
Copy link
Contributor

@str4t0m str4t0m commented May 27, 2021

This commit resolves the undefined behavior caused by missing timing.sjw
initialization.

As suggested in #35487 include only the bug-fix, such that it can still be merged in 2.6.
Fixes: #35737

@alexanderwachter
Copy link
Member

Thanks!

@str4t0m
Copy link
Contributor Author

str4t0m commented May 27, 2021

@martinjaeger, @legoabram, or @erwango you have reviewed the initial commit, might one of you have a look at this?

@alexanderwachter alexanderwachter added the bug The issue is a bug, or the PR is fixing a bug label May 27, 2021
Copy link
Member

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

This commit resolves the undefined behviour caused by missing timing.sjw
initialization.

Signed-off-by: Thomas Stranger <[email protected]>
@str4t0m
Copy link
Contributor Author

str4t0m commented May 27, 2021

Pushed again to move it before the ifdef instead of adding it twice.

@galak galak added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label May 27, 2021
@galak galak merged commit 12c80eb into zephyrproject-rtos:main May 27, 2021
@str4t0m str4t0m deleted the mcan_init_sjw branch May 27, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: CAN bug The issue is a bug, or the PR is fixing a bug Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

drivers: can: mcan: sjw not initialized when CAN_FD_MODE is enabled

4 participants