Skip to content

Conversation

@jfischer-no
Copy link
Contributor

Despite documentation macros RING_BUF_*_DECLARE_* do not
define struct ring_buf as static. Add static specifier to
struct ring_buf in RING_BUF_*_DECLARE_* macros.

Fixes: #36608

Despite documentation macros RING_BUF_*_DECLARE_* do not
define struct ring_buf as static. Add static specifier to
struct ring_buf in RING_BUF_*_DECLARE_* macros.

Fixes: zephyrproject-rtos#36608

Signed-off-by: Johann Fischer <[email protected]>
@jfischer-no jfischer-no requested a review from nashif June 29, 2021 07:52
@github-actions github-actions bot added the area: API Changes to public APIs label Jun 29, 2021
@jfischer-no jfischer-no added bug The issue is a bug, or the PR is fixing a bug and removed area: API Changes to public APIs labels Jun 29, 2021
@jfischer-no jfischer-no reopened this Jun 29, 2021
@jfischer-no jfischer-no added the DNM This PR should not be merged (Do Not Merge) label Jun 29, 2021
@github-actions github-actions bot added the area: API Changes to public APIs label Jun 29, 2021
@jfischer-no
Copy link
Contributor Author

Copy link
Member

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed #36608

@carlescufi carlescufi requested a review from nordic-krch July 12, 2021 14:21
@carlescufi
Copy link
Member

ycsin added a commit to ycsin/zephyr that referenced this pull request Jul 31, 2021
@nordic-krch
Copy link
Contributor

I think we need to remove word Statically and keep it global. I don't see an option to modify macro to allow something like static RING_BUF_DECLARE(foo). If static ring buffer macros are needed macro can be extended with option or new macro added.

@nordic-krch
Copy link
Contributor

Created #37565

@jfischer-no
Copy link
Contributor Author

close in favor of #37926

@jfischer-no jfischer-no deleted the pr-fix-36608 branch August 25, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: API Changes to public APIs area: Base OS Base OS Library (lib/os) bug The issue is a bug, or the PR is fixing a bug DNM This PR should not be merged (Do Not Merge)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to compile USB console example with uart_mux

6 participants