samples: Bluetooth: Fix conf in ISO connected benchmark #36705
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration of the sample included CONFIG_BT_ISO=y. The CONFIG_BT_ISO is defined as hidden option in subsys/bluetooth/Kconfig. That makes build of the sample to fail. It blocks PRs in the CI if sample is build. The commit fixes the issue by change of CONFIG_BT_ISO to CONFIG_BT_ISO_UNICAST. Signed-off-by: Piotr Pryga <[email protected]>
ppryga-nordic
requested review from
Vudentz,
jhedberg and
joerchan
as code owners
ppryga-nordic
referenced
this pull request
Jul 3, 2021
Pass enh ack data injection arguments to the nRF5 radio driver. Signed-off-by: Lukasz Maciejonczyk <[email protected]>
This was referenced Jul 3, 2021
Thalley
previously approved these changes
Jul 5, 2021
cvinayak
approved these changes
Jul 6, 2021
|
The PR that this fixes has been reverted and a new one has been created including this fix: #36752 so this can be closed. |
|
Closing due to revert of PR #31875. |
MaureenHelm
deleted the
github-samples-fix-kconfig-iso-connected-benchmark
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration of the sample included CONFIG_BT_ISO=y.
The CONFIG_BT_ISO is defined as hidden option in
subsys/bluetooth/Kconfig. That makes build of the sample
to fail. It blocks PRs in the CI if sample is build.
The commit fixes the issue by change of CONFIG_BT_ISO
to CONFIG_BT_ISO_UNICAST.
Fixes build issue in PR: #31875
Signed-off-by: Piotr Pryga [email protected]