Skip to content

Conversation

@nandojve
Copy link
Member

PSoC-6 have different priority bit masks for cortex-m0+ and cortex-m4.

M0: 0-3 (2 bits of NVIC prio, no prio reserved by the kernel)
M4: 0-6 (3 bits of NVIC prio, one level reserved by the kernel)

The current macro that gets priority level value from devicetree apply same value from cortex-m4 on cortex-m0+. This add missing indirection to get from intmux node the correct cortex-m0+ priority level value.

Signed-off-by: Gerson Fernando Budke [email protected]

@nandojve nandojve requested review from carlescufi and galak August 11, 2021 11:26
@nandojve nandojve added this to the v2.7.0 milestone Aug 11, 2021
@nandojve
Copy link
Member Author

The #37576 still necessary to fix build errors.

Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, just a non blocking suggestion.

@nandojve nandojve force-pushed the psoc6_fix_m0_irq_prio branch from b3a3ccb to a794144 Compare August 11, 2021 14:28
@nandojve
Copy link
Member Author

Just to mention, I was expecting a failure on CI since #37576 was not merged yet.

@galak
Copy link
Contributor

galak commented Aug 11, 2021

Just to mention, I was expecting a failure on CI since #37576 was not merged yet.

Merged #37576, you can rebase now.

PSoC-6 have different priority bit masks for cortex-m0+ and cortex-m4.

M0: 0-3 (2 bits of NVIC prio, no prio reserved by the kernel)
M4: 0-6 (3 bits of NVIC prio, one level reserved by the kernel)

The current macro that gets priority level value from devicetree apply
same value from cortex-m4 on cortex-m0+.  This add missing indirection
to get from intmux node the correct cortex-m0+ priority level value.

Signed-off-by: Gerson Fernando Budke <[email protected]>
@nandojve nandojve force-pushed the psoc6_fix_m0_irq_prio branch from a794144 to 649a6e9 Compare August 11, 2021 15:45
@nandojve
Copy link
Member Author

Just to mention, I was expecting a failure on CI since #37576 was not merged yet.

Merged #37576, you can rebase now.

Done!

@nandojve nandojve added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels Aug 11, 2021
@cfriedt cfriedt merged commit a42890f into zephyrproject-rtos:main Aug 11, 2021
@nandojve nandojve deleted the psoc6_fix_m0_irq_prio branch August 24, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants