- 
                Notifications
    You must be signed in to change notification settings 
- Fork 8.2k
ARC: MWDT: add C++ support #37653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            cfriedt
  merged 6 commits into
  zephyrproject-rtos:main
from
evgeniy-paltsev:rff-mwdt-cpp-support-w-cpp-pr-v12
  
      
      
   
  Aug 22, 2021 
      
    
                
     Merged
            
            ARC: MWDT: add C++ support #37653
                    cfriedt
  merged 6 commits into
  zephyrproject-rtos:main
from
evgeniy-paltsev:rff-mwdt-cpp-support-w-cpp-pr-v12
  
      
      
   
  Aug 22, 2021 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    abrodkin
  
              
              approved these changes
              
                  
                    Aug 13, 2021 
                  
              
              
            
            
The MWDT toolchain provides two C++ libraries. Let's use LLVM C++ library. Signed-off-by: Eugeniy Paltsev <[email protected]> Signed-off-by: Evgeniy Paltsev <[email protected]>
As of today we have libraries provided by MWDT build with stackcheck enabled. So we have to provide dummy _fstack, _estack to make it working. Signed-off-by: Eugeniy Paltsev <[email protected]> Signed-off-by: Evgeniy Paltsev <[email protected]>
Add missing properties for C++14, C++17 standards support Signed-off-by: Eugeniy Paltsev <[email protected]> Signed-off-by: Evgeniy Paltsev <[email protected]>
45c9b4f    to
    fd43adf      
    Compare
  
    Add cpp.libcxx.arcmwdtlib to test C++ library from MWDT toolchain (with MWDT C library) Signed-off-by: Eugeniy Paltsev <[email protected]> Signed-off-by: Evgeniy Paltsev <[email protected]>
Fix include path of headers provided by MWDT toolchain for the case of MWDT C/C++ lib usage. Signed-off-by: Eugeniy Paltsev <[email protected]> Signed-off-by: Evgeniy Paltsev <[email protected]>
fd43adf    to
    906211d      
    Compare
  
    ARC MWDT doesn't support building Zephyr as an native application (CONFIG_NATIVE_APPLICATION). ARC MWDT doesn't support building with CONFIG_NEWLIB_LIBC as it doesn't have newlib. Let's explicitly forbid to use these Kconfig options for the MWDT toolchain. Signed-off-by: Eugeniy Paltsev <[email protected]> Signed-off-by: Evgeniy Paltsev <[email protected]>
906211d    to
    f33e52d      
    Compare
  
    
              
                    ruuddw
  
              
              approved these changes
              
                  
                    Aug 19, 2021 
                  
              
              
            
            
| @evgeniy-paltsev - is this ready to merge? | 
              
                    stephanosio
  
              
              approved these changes
              
                  
                    Aug 21, 2021 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
              
                    alexanderwachter
  
              
              approved these changes
              
                  
                    Aug 21, 2021 
                  
              
              
            
            
| 
 Yes, it's ready. | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    area: API
  Changes to public APIs 
  
    area: ARC
  ARC Architecture 
  
    area: Build System
  
    area: C++
  
    area: Tests
  Issues related to a particular existing or missing test 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Add C++ libs support when building with MWDT toolchain.