Skip to content

Conversation

@aunsbjerg
Copy link
Contributor

Enables the mcux ethernet driver and pin muxes on the
mimxrt1024_evk board in the same way as is done on the
mimxrt1020_evk and mimxrt1050_evk.

Documentation updated accordingly.

Signed-off-by: Mikkel Jakobsen [email protected]

@aunsbjerg
Copy link
Contributor Author

DNM until I iron some issues I only found after rebasing to latest main.

@aunsbjerg aunsbjerg removed the DNM This PR should not be merged (Do Not Merge) label Sep 1, 2021
@aunsbjerg
Copy link
Contributor Author

Added the quickfix from #38186 and now everything works as expected.

Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add netif:eth to the supported list in the board yaml.

@aunsbjerg
Copy link
Contributor Author

Please add netif:eth to the supported list in the board yaml.

The supported list was empty, so I took the libery of adding the basic features based on the mimxrt1020_evk. Let me know if you'd rather just have netif:eth.

Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add netif:eth to the supported list in the board yaml.

The supported list was empty, so I took the libery of adding the basic features based on the mimxrt1020_evk. Let me know if you'd rather just have netif:eth.

Thanks for doing this. Unfortunately it uncovered some unrelated issues, so unless you want to fix those too, I suggest limiting the list to netif:eth for now so we can get this PR merged before the window closes tomorrow.

@MaureenHelm MaureenHelm added this to the v2.7.0 milestone Sep 2, 2021
@MaureenHelm
Copy link
Member

Needs rebase

Mikkel Jakobsen added 2 commits September 3, 2021 17:56
Enables the mcux ethernet driver and pin muxes on the
mimxrt1024_evk board in the same way as is done on the
mimxrt1020_evk and mimxrt1050_evk.

Documentation updated accordingly.

Signed-off-by: Mikkel Jakobsen <[email protected]>
the mimxrt1024_evk actually supports these, they were just never
added for some reason.

Signed-off-by: Mikkel Jakobsen <[email protected]>
@cfriedt cfriedt merged commit 637e9f2 into zephyrproject-rtos:main Sep 5, 2021
@aunsbjerg aunsbjerg deleted the mimxrt1024-evk-eth branch September 6, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants