shell: remove Kconfig option CONFIG_UART_SHELL_ON_DEV_NAME #37902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfischer-no
requested review from
carlescufi,
gmarull,
jakub-uC,
mbolivar-nordic and
nordic-krch
github-actions
bot
added
area: Documentation
area: Samples
gmarull
approved these changes
Aug 24, 2021
stephanosio
requested changes
Aug 24, 2021
Follow up on commit bfd45e5 ("drivers: remove Kconfig option CONFIG_UART_CONSOLE_ON_DEV_NAME") Now we can also remove Kconfig option CONFIG_UART_CONSOLE_ON_DEV_NAME since all UART drivers are converted to devicetree and we can just use DEVICE_DT_GET(DT_CHOSEN(zephyr_shell_uart)). Signed-off-by: Johann Fischer <[email protected]>
jfischer-no
force-pushed
the
pr-remove_shell_on_dev_name
branch
from
6eacd9c to
599b6a9
Compare
stephanosio
approved these changes
Aug 24, 2021
nashif
approved these changes
Aug 24, 2021
coreboot-bot
pushed a commit
to coreboot/chrome-ec
that referenced
this pull request
Sep 7, 2021
In Zephyr 2.7+, CONFIG_UART_SHELL_ON_DEV_NAME is removed in favor of using the zephyr,shell-uart device chosen by the UART driver. Since we choose zephyr,shell-uart on all of our boards, we are clear to make this change ahead of the v2.7 uprev. Also see zephyrproject-rtos/zephyr#37902. BUG=b:198824039 BRANCH=none TEST=zmake testall TEST=compile posix-ec with v2.7_rc1 Signed-off-by: Jack Rosenthal <[email protected]> Change-Id: Ic066ce0617fa900ae7c1c96a2cbece0b698764bc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3142750 Reviewed-by: Keith Short <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on commit bfd45e5
("drivers: remove Kconfig option CONFIG_UART_CONSOLE_ON_DEV_NAME")
Now we can also remove Kconfig option CONFIG_UART_CONSOLE_ON_DEV_NAME
since all UART drivers are converted to devicetree and we can just use
DEVICE_DT_GET(DT_CHOSEN(zephyr_shell_uart)).