usb: cdc_acm: trigger TX IRQ when CDC ACM class is ready #37924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfischer-no
approved these changes
Aug 25, 2021
jfischer-no
added
area: USB
|
Fixed lines length in commit message. |
stephanosio
requested changes
Aug 26, 2021
Before commit 4f2682b ("usb: cdc_acm: avoid spurious interrupt on configured or resume events") spurious rx-interrupt provided start to read shell tx ring buffer by CDC ACM UART. Now shell log backend not transmit data, until CDC ACM UART received data from host. This PR added invoking interrupt callback if tx interrupt is enable, when CDC ACM class go to configured state, and flag tx_ready go to true. Signed-off-by: Grixa Yrev <[email protected]>
stephanosio
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before commit 4f2682b
("usb: cdc_acm: avoid spurious interrupt on configured or resume events")
spurious rx-interrupt provided start to read shell tx ring buffer by
CDC ACM UART. Now shell log backend not transmit data, until CDC ACM UART
received data from host.
This PR added invoking interrupt callback if tx interrupt is enable,
when CDC ACM class go to configured state, and flag tx_ready go to true.
Signed-off-by: Grixa Yrev [email protected]