Bluetooth: Controller: Make node rx release code conditionally reusable #37930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvinayak
requested review from
carlescufi,
kruithofa and
thoh-ot
as code owners
cvinayak
commented
Aug 25, 2021
Make the block of code that is used to release node rx with type NODE_RX_TYPE_RELEASE to be conditionally available for other Kconfig selectable features like Extended Scanning. Previously it was only available for CONFIG_BT_CONN, but now Extended Scanning with LLL scheduling releases node rx when radio event is closed due to failure to receive an auxiliary PDU. Relates to commit 2feffaf ("Bluetooth: Controller: Release LLL scheduling aux on incomplete data"). Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_node_rx_release_refactor
branch
from
918f89c to
31e6c89
Compare
ppryga-nordic
approved these changes
Aug 26, 2021
kruithofa
approved these changes
Aug 27, 2021
andrzej-kaczmarek
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the block of code that is used to release node rx with
type NODE_RX_TYPE_RELEASE to be conditionally available for
other Kconfig selectable features like direction finding.
Currently it was only available for CONFIG_BT_CONN.
Signed-off-by: Vinayak Kariappa Chettimada [email protected]