- 
                Notifications
    You must be signed in to change notification settings 
- Fork 8.2k
runners: openocd: add support for custom reset halt command #38025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            nashif
  merged 1 commit into
  zephyrproject-rtos:main
from
henrikbrixandersen:openocd_reset_halt
  
      
      
   
  Aug 27, 2021 
      
    
                
     Merged
            
            runners: openocd: add support for custom reset halt command #38025
                    nashif
  merged 1 commit into
  zephyrproject-rtos:main
from
henrikbrixandersen:openocd_reset_halt
  
      
      
   
  Aug 27, 2021 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    a58cdba    to
    e390422      
    Compare
  
    
              
                    chrta
  
              
              approved these changes
              
                  
                    Aug 26, 2021 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This way now we can also omit the reset when starting the debugserver.
I have just one unrelated (and non-blocking) question/comment.
              
                    mbolivar-nordic
  
              
              suggested changes
              
                  
                    Aug 26, 2021 
                  
              
              
            
            
1ea6f4a    to
    76d10eb      
    Compare
  
    
              
                    mbolivar-nordic
  
              
              approved these changes
              
                  
                    Aug 27, 2021 
                  
              
              
            
            
Add support for specifying a custom OpenOCD command to be used for resetting and halting a target. As noted in the OpenOCD documentation, not all targets support the "reset halt" command for halt-on-reset. Some targets support a software emulation via the "soft_reset_halt" command. Other targets may require a custom command (e.g. a command defined in the target configuration file). Signed-off-by: Henrik Brix Andersen <[email protected]>
76d10eb    to
    31d416a      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Add support for specifying a custom OpenOCD command to be used for resetting and halting a target.
As noted in the OpenOCD documentation, not all targets support the "reset halt" command for halt-on-reset.
Some targets support a software emulation via the "soft_reset_halt" command. Other targets may require a custom command (e.g. a command defined in the target configuration file).
Signed-off-by: Henrik Brix Andersen [email protected]