Bluetooth: Controller: Fix radio packet size for Extended Scanning #38027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvinayak
requested review from
carlescufi,
kruithofa and
thoh-ot
as code owners
andrzej-kaczmarek
requested changes
Aug 26, 2021
There was a problem hiding this comment.
I think it would be better to redefine PDU_AC_PAYLOAD_SIZE_MAX if ext scanner is enabled since this will also update PDU_RX_NODE_POOL_ELEMENT_SIZE (<- PDU_ADVERTIZE_SIZE <- PDU_AC_LL_SIZE_MAX <- PDU_AC_PAYLOAD_SIZE_MAX) - otherwise we may receive PDU and corrupt some memory outside buffer.
There was a problem hiding this comment.
ok, I will review the Rx Pool element size, and update this PR later today.
Minor rearrange of rx packet set statements after radio configuration function calls. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix maximum radio packet size configuration to use 255 bytes for Extended Scanning and Periodic Synchronization. Add a Kconfig option so that application can reduce RAM usage if a specific user scenario can live with smaller PDU receptions. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Remove unused legacy PDU size extra defines. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_max_pkt_size_fix
branch
from
626777e to
5b27848
Compare
ppryga-nordic
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix maximum radio packet size configuration to use 255 bytes
for Extended Scanning and Periodic Synchronization.
Signed-off-by: Vinayak Kariappa Chettimada [email protected]