Skip to content

drivers: display: Added support for 2.7inch epaper display #38306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

drivers: display: Added support for 2.7inch epaper display #38306

wants to merge 2 commits into from

Conversation

@DineshDK03
Copy link
Contributor

@DineshDK03 DineshDK03 commented Sep 3, 2021 •
edited
Loading

Added new display driver ek79652

Signed-off-by: Dinesh Kumar K [email protected]

@github-actions github-actions bot added area: API Changes to public APIs area: Boards area: Devicetree area: Devicetree Binding PR modifies or adds a Device Tree binding area: Documentation area: Samples Samples area: Shields Shields (add-on boards) labels Sep 3, 2021
@DineshDK03 DineshDK03 force-pushed the ek79652 branch 2 times, most recently from 860a684 to b5ff56c Compare September 10, 2021 05:59
@erwango erwango added this to the v3.0.0 milestone Sep 10, 2021
mbolivar-nordic
mbolivar-nordic suggested changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thanks for the patch. A few comments about the devicetree from my side.

samples/subsys/display/lvgl/src/main.c Outdated
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on here? This is undefined, so the #ifdef GDEW027W3 below is dead code.

If you need to match on a particular piece of hardware, then I think we need to get around to removing CONFIG_LVGL_DISPLAY_DEV_NAME and using a devicetree node instead.

Then you can either:

  1. match on its compatible with DT_NODE_HAS_COMPAT: https://docs.zephyrproject.org/latest/reference/devicetree/api.html#c.DT_NODE_HAS_COMPAT
  2. add some other devicetree property that the driver or application can use to decide to use display_refresh instead of display_blanking_off

Copy link
Contributor Author

@DineshDK03 DineshDK03 Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbolivar-nordic As suggested , Inorder match for this particular hardware, used DT_NODE_HAS_COMPAT.

Copy link
Contributor

@mbolivar-nordic mbolivar-nordic Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need to match on a particular piece of hardware, then I think we need to get around to removing CONFIG_LVGL_DISPLAY_DEV_NAME

This part was important, can you please do that too?

What I mean is that Kconfig options which just specify a device name have been deprecate for a long time now that the devicetree.h API has been stabilized and the device model has been updated to use devicetree nodes.

The thing to do now is to just get the struct device* from a devicetree pointer, using things like DEVICE_DT_GET, DEVICE_DT_GET_ANY, or DEVICE_DT_GET_ONE.

Copy link
Contributor Author

@DineshDK03 DineshDK03 Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed reply, if we remove CONFIG_LVGL_DISPLAY_DEV_NAME and get the device using any of the DT api , it will then go into hardware specific, also this type of west build may create conflicts right?

Copy link
Contributor

@mbolivar-nordic mbolivar-nordic Nov 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reply, but I do not understand. What conflicts are you referring to?

Copy link
Contributor Author

@DineshDK03 DineshDK03 Nov 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought, if --DSHIELD overlay and device name used inside main.c will create conflicts but it wont. So modified the requested changes

parthitce
parthitce approved these changes Nov 11, 2021
View reviewed changes
@DineshDK03 DineshDK03 force-pushed the ek79652 branch 2 times, most recently from ab79dd8 to 7bf9271 Compare November 12, 2021 10:06
parthitce
parthitce previously approved these changes Nov 16, 2021
View reviewed changes
erwango
erwango previously approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on shield part

@DineshDK03 DineshDK03 force-pushed the ek79652 branch 2 times, most recently from 23ff9ad to 58d896d Compare November 23, 2021 18:46
@DineshDK03 DineshDK03 requested a review from dleach02 as a code owner November 23, 2021 18:46
@parthitce parthitce reopened this Jun 13, 2022
@zephyrbot zephyrbot requested a review from gmarull June 13, 2022 08:54
@DineshDK03 DineshDK03 force-pushed the ek79652 branch 2 times, most recently from b1e10fa to 71d55e3 Compare June 13, 2022 10:30
@DineshDK03
Copy link
Contributor Author

DineshDK03 commented Jun 13, 2022 •
edited
Loading

@jfischer-no fixed all the comments you mentioned, except this #38306 (comment) , the below image will explain that issue.

1st image: CS pin keeps LOW while sending data value (display not/won't work)
2nd image: CS pin toggles for each data value (display works)

SPI_buffer_combined
SPI_buffer_split

@github-actions
Copy link

github-actions bot commented Aug 13, 2022

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Aug 13, 2022
@jfischer-no
Copy link
Contributor

jfischer-no commented Aug 16, 2022

@DineshDK03 Please take a look at the latest changes @andysan has made in https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/display/uc81xx.c and https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/display/ssd16xx.c, and try to align your driver with these. In the commit history, I see shield support before the driver, this should be the other way around.

@jfischer-no jfischer-no requested review from andysan and removed request for MaureenHelm, avisconti, carlescufi and galak August 16, 2022 10:06
@andysan
Copy link
Contributor

andysan commented Aug 16, 2022

@DineshDK03 Please take a look at the latest changes @andysan has made in https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/display/uc81xx.c and https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/display/ssd16xx.c, and try to align your driver with these. In the commit history, I see shield support before the driver, this should be the other way around.

I would suggest going even further. As far as I can tell, the register layout of this chip is very close (almost identical) to the UltraChip EPD drivers. A quick look at the data sheet suggests that you can most likely just add a quirk structure for this device in UC81xx and it should mostly just work out of the box. You might want to have a look at #48383 if you go down that route.

@github-actions github-actions bot removed the Stale label Aug 17, 2022
@github-actions
Copy link

github-actions bot commented Oct 20, 2022

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Oct 20, 2022
@zephyrbot zephyrbot requested review from avisconti and galak October 26, 2022 04:31
@DineshDK03
boards: shields: Add support for 2.7inch epaper display
1d9eb17 
Add support for gdew027w3 2.7inch epaper display.

Signed-off-by: Dinesh Kumar K <[email protected]>
@DineshDK03
drivers: display: Added support for 2.7inch epaper display
84c2b85 
Added new display driver ek79652 for 2.7inch epaper display.

Signed-off-by: Dinesh Kumar K <[email protected]>
@github-actions github-actions bot closed this Nov 10, 2022
@DineshDK03 DineshDK03 mentioned this pull request Jun 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthitce parthitce parthitce left review comments

@nashif nashif Awaiting requested review from nashif

@erwango erwango Awaiting requested review from erwango

@gmarull gmarull Awaiting requested review from gmarull

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@mbolivar-nordic mbolivar-nordic Awaiting requested review from mbolivar-nordic

@andysan andysan Awaiting requested review from andysan

@avisconti avisconti Awaiting requested review from avisconti

@galak galak Awaiting requested review from galak

Assignees

@erwango erwango

Labels

area: API Changes to public APIs area: Boards area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree area: Display area: Documentation area: Samples Samples area: Shields Shields (add-on boards) Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.