Bluetooth: Mesh: Fix crash on disconnect #39098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bt_mesh_proxy_role_setup() is called conditionally when peer is connected and gatt_disconnected() is always called. This leads to unbalance in role->conn reference count and crash. Instead of hot-fixing this in gatt_disconnected(), this commit adds proper bt_mesh_proxy_role_cleanup() API that is called by roles implementations if cleanup is needed. Signed-off-by: Szymon Janc <[email protected]>
sjanc
requested review from
Vudentz,
jhedberg,
joerchan and
trond-snekvik
as code owners
Contributor
Author
|
Fixes crash introduced by #36871 |
trond-snekvik
approved these changes
Oct 4, 2021
michal-narajowski
approved these changes
Oct 4, 2021
LingaoM
reviewed
Oct 8, 2021
| } | ||
|
|
||
| cli = NULL; | ||
| if (cli) { |
Contributor
There was a problem hiding this comment.
Sorry for the late reply. Your modification is very good, but I have a little doubt: Since there is no environment support of BBSIM, I can only simply test the functions of PB-GATT and Proxy locally, and it seems that there is no crash.
Contributor
Author
There was a problem hiding this comment.
it is very easy to reproduce the crash before this fix: just connect as a central to any device that doesn't support PB-GATT and disconnect.
(we noticed this in autopts run where all BLE Host tests that IUT is central were failing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_mesh_proxy_role_setup() is called conditionally when peer is
connected and gatt_disconnected() is always called. This leads
to unbalance in role->conn reference count and crash.
Instead of hot-fixing this in gatt_disconnected(), this commit adds
proper bt_mesh_proxy_role_cleanup() API that is called by roles
implementations if cleanup is needed.
Signed-off-by: Szymon Janc [email protected]