riscv: linker.ld: Fix undefined reference linker error

[nandojve]

The commit a28830b aligned the data and rename some symbols. However there are two symbols at riscv linker script that were missing, which causes below linker error:

kernel/xip.c:28: undefined reference to `__itcm_load_start'
kernel/xip.c:43: undefined reference to `__dtcm_data_load_start'

Rename below symbols to fix the issues.

__itcm_rom_start -> __itcm_load_start
__dtcm_data_rom_start -> __dtcm_data_load_start

Signed-off-by: Gerson Fernando Budke [email protected]

[henrikbrixandersen]

Do we have a way of reproducing a build error or testing this?

[tejlmand]

The commit 65a2de8 aligned the data and rename some symbols. However there are two symbols at riscv linker script that were missing, which causes below linker error:

Most likely happened because those PRs were crossing each other:
#36140
and
#37421

and thus the symbols where not present in the initial renaming update 😞

[nashif]

if this needs to go to 2.7, please file a bug.

[henrikbrixandersen]

The approvals are nice, but I would still like to know why the undefined references were not found in CI.

[cfriedt]

The approvals are nice, but I would still like to know why the undefined references were not found in CI.

Agreed. We really do need tests to accompany code changes on a more regular basis.

[cfriedt]

Just adding DNM until after v2.7.0 is released

[github-actions]

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.