tests: bluetooth: tester: Add support for L2CAP channels options #39500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for better control over IUT behaviour by Upper Tester. PTS and TS require inconsistent behaviour in terms of how IUT should return credits. Some tests require return on explicit UT request and some require that IUT returns credits autonomously. Signed-off-by: Szymon Janc <[email protected]>
github-actions
bot
added
the
area: Tests
jhedberg
approved these changes
Oct 18, 2021
sjanc
added
the
area: Bluetooth Qualification
joerchan
reviewed
Oct 18, 2021
| CONTROLLER_INDEX, recv_cb_buf, sizeof(*ev) + buf->len); | ||
|
|
||
| if (!chan->pending_credit) { | ||
| if (chan->hold_credit && !chan->pending_credit) { |
Contributor
There was a problem hiding this comment.
Just a suggestion that this might be better named as "user_confirm". Since that is how returning EINPROGRESS is documented
Contributor
Author
There was a problem hiding this comment.
I wanted to keep chan option same as in BTP spec (and not zephyr's implementation detail)
joerchan
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for better control over IUT behaviour by Upper Tester.
PTS and TS require inconsistent behaviour in terms of how IUT should
return credits. Some tests require return on explicit UT request and
some require that IUT returns credits autonomously.
Signed-off-by: Szymon Janc [email protected]