Bluetooth: Add support for SMP Key Rejected error code #39511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: API
sjanc
added
area: Bluetooth Qualification
jhedberg
approved these changes
Oct 18, 2021
This error code informs that peer device rejected key during keys distribution phase. Signed-off-by: Szymon Janc <[email protected]>
This event is sent if pairing failed. Signed-off-by: Szymon Janc <[email protected]>
sjanc
force-pushed
the
smp_key_rejected
branch
from
7599137 to
e8ea882
Compare
Contributor
Author
|
gentle ping |
Thalley
approved these changes
Nov 1, 2021
Contributor
Thalley
left a comment
Thalley
left a comment
There was a problem hiding this comment.
Minor comment, otherwise LGTM
| struct gap_bond_pairing_failed_ev ev; | ||
| const bt_addr_le_t *addr = bt_conn_get_dst(conn); | ||
|
|
||
| memcpy(ev.address, addr->a.val, sizeof(ev.address)); |
Contributor
There was a problem hiding this comment.
Minor: Typically when ignoring return values, we cast to void:
Suggested change
| memcpy(ev.address, addr->a.val, sizeof(ev.address)); | |
| (void)memcpy(ev.address, addr->a.val, sizeof(ev.address)); |
joerchan
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.