Skip to content

tests: bluetooth: tester: Add support for security_changed callback #39576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2021
Merged

tests: bluetooth: tester: Add support for security_changed callback #39576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions tests/bluetooth/tester/src/gap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,41 @@ static void le_param_updated(struct bt_conn *conn, uint16_t interval,
CONTROLLER_INDEX, (uint8_t *) &ev, sizeof(ev));
}

static void le_security_changed(struct bt_conn *conn, bt_security_t level,
enum bt_security_err err)
{
const bt_addr_le_t *addr = bt_conn_get_dst(conn);
struct gap_sec_level_changed_ev sec_ev;
struct gap_bond_lost_ev bond_ev;

switch (err) {
case BT_SECURITY_ERR_SUCCESS:
memcpy(sec_ev.address, addr->a.val, sizeof(sec_ev.address));
sec_ev.address_type = addr->type;
/* enum matches BTP values */
sec_ev.sec_level = level;

tester_send(BTP_SERVICE_ID_GAP, GAP_EV_SEC_LEVEL_CHANGED,
CONTROLLER_INDEX, (uint8_t *) &sec_ev, sizeof(sec_ev));
Comment on lines +123 to +124
Copy link
Member

@jhedberg jhedberg Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but seems like tester_send() could benefit from an API improvement by making the second last parameter const void * to avoid explicit typecasts.

Copy link
Contributor Author

@sjanc sjanc Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this and also use of bt_addr_t is on my todo

break;
case BT_SECURITY_ERR_PIN_OR_KEY_MISSING:
memcpy(bond_ev.address, addr->a.val, sizeof(bond_ev.address));
bond_ev.address_type = addr->type;

tester_send(BTP_SERVICE_ID_GAP, GAP_EV_BOND_LOST,
CONTROLLER_INDEX, (uint8_t *) &bond_ev, sizeof(bond_ev));
break;
default:
break;
}
}

static struct bt_conn_cb conn_callbacks = {
.connected = le_connected,
.disconnected = le_disconnected,
.identity_resolved = le_identity_resolved,
.le_param_updated = le_param_updated,
.security_changed = le_security_changed,
};

static void supported_commands(uint8_t *data, uint16_t len)
Expand Down