Skip to content

Zync: a universal Zephyr synchronization primitive #48340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Zync: a universal Zephyr synchronization primitive #48340

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4587595
DO NOT REVIEW - SQUASHED PATCHES FROM #51924
andyross Jul 9, 2022
44ecced
kernel: Add waitq "lazy init", move z_waitq_head()
andyross Jul 2, 2022
b83149a
tests/lib/ringbuffer: Use k_mutex, not sys_mutex
andyross Oct 9, 2022
69486ab
subsys/tracing: Remove obj_tracking for semaphores and mutexes
andyross Nov 1, 2022
a05e2d4
kernel: Clean up DYNAMIC_OBJECTS vs. HEAP_MEM_POOL_SIZE
andyross Nov 6, 2022
2406ef8
tests/sys_mutex: Fix scheduling/priority behavior
andyross Nov 7, 2022
d5814ea
tests/kernel/sys_mutex: Remove noop userspace test
andyross Nov 7, 2022
648a8e1
tests/kernel/sched/metairq: Correct scheduling point behavior
andyross Nov 7, 2022
8ea6928
kernel: Add k_zync, a universal Zephyr synchronization primitive.
andyross Jul 2, 2022
2ddc12a
tests/kernel: Add zync unit test
andyross Jul 9, 2022
2218a8c
tests/kernel/mutex_api: Adjust kobj type for zync
andyross Oct 9, 2022
77ca333
tests/benchmarks/latency_measure: Needs recursive zyncs
andyross Nov 1, 2022
7face79
kernel/sched: Refactor, unready_thread()
andyross Nov 14, 2022
7956e7a
kernel/sched: refactor wake()
andyross Nov 14, 2022
d293aca
kernel/zync: Handle the case of aborted just-awoken threads
andyross Nov 14, 2022
3b715e3
tests/kernel/zync: Add case for abort/recovery
andyross Nov 14, 2022
fccce4f
kernel/zync: Augment k_zync() timeout loop to be optionally stricter
andyross Nov 14, 2022
988f530
tests/kernel/zync: Add a case to exercise strict timeouts
andyross Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions tests/lib/ringbuffer/src/concurrent.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#include <zephyr/ztest.h>
#include <zephyr/ztress.h>
#include <zephyr/sys/ring_buffer.h>
#include <zephyr/sys/mutex.h>
#include <zephyr/random/rand32.h>
#include <stdint.h>

Expand All @@ -24,19 +23,19 @@
#define VALUE 0xb
#define TYPE 0xc

static ZTEST_BMEM SYS_MUTEX_DEFINE(mutex);
K_MUTEX_DEFINE(mutex);
Copy link

@desowin desowin Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you dropping the static and ZTEST_BMEM qualifiers?

RING_BUF_ITEM_DECLARE(ringbuf, RINGBUFFER);
static uint32_t output[LENGTH];
static uint32_t databuffer1[LENGTH];
static uint32_t databuffer2[LENGTH];

static void data_write(uint32_t *input)
{
sys_mutex_lock(&mutex, K_FOREVER);
k_mutex_lock(&mutex, K_FOREVER);
int ret = ring_buf_item_put(&ringbuf, TYPE, VALUE,
input, LENGTH);
zassert_equal(ret, 0);
sys_mutex_unlock(&mutex);
k_mutex_unlock(&mutex);
}

static void data_read(uint32_t *output)
Expand All @@ -45,9 +44,9 @@ static void data_read(uint32_t *output)
uint8_t value, size32 = LENGTH;
int ret;

sys_mutex_lock(&mutex, K_FOREVER);
k_mutex_lock(&mutex, K_FOREVER);
ret = ring_buf_item_get(&ringbuf, &type, &value, output, &size32);
sys_mutex_unlock(&mutex);
k_mutex_unlock(&mutex);

zassert_equal(ret, 0);
zassert_equal(type, TYPE);
Expand Down