Add options needed for GDEM029T94 initialization #49371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galak
requested changes
Aug 22, 2022
Contributor
galak
left a comment
galak
left a comment
There was a problem hiding this comment.
Replace magic number 0x37 in code and dts binding with register name. Not sure if it is SSD16XX_CMD_OTP_SELECTION_CTRL
| } | ||
|
|
||
| if (config->display_option_data.len) { | ||
| err = ssd16xx_write_cmd(dev, 0x37, |
Contributor
There was a problem hiding this comment.
SSD16XX_CMD_OTP_SELECTION_CTRL instead of 0x37??
| display-option-data: | ||
| type: uint8-array | ||
| required: false | ||
| description: setup 0x37 register for setting ping pong update |
Contributor
There was a problem hiding this comment.
what is the register name of 0x37. Use that instead.
Author
|
Made second try to merge code in #49377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDEM029T94 is used in 2.9inch_e-Paper_Module_V2.