Skip to content

Add options needed for GDEM029T94 initialization #49693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add options needed for GDEM029T94 initialization #49693

wants to merge 3 commits into from

Conversation

@korneliuszo
Copy link

@korneliuszo korneliuszo commented Aug 30, 2022

Supersets #49377

@korneliuszo korneliuszo requested a review from galak as a code owner August 30, 2022 16:09
@korneliuszo korneliuszo mentioned this pull request Aug 30, 2022
Closed
@carlescufi
Copy link
Member

carlescufi commented Aug 30, 2022

@korneliuszo please do not close Pull Requests. Instead, edit your commits with git rebase -i and git commit --amend and then force-push with git push -f.

@carlescufi
Copy link
Member

carlescufi commented Aug 30, 2022

@korneliuszo thanks!
Note that the twister-build issues are not related to your PR and will be fixed shortly.

@korneliuszo @stephanosio
drivers: display:SSD16XX: dtb binding for SSD16XX_CMD_UPDATE_CTRL1
f38cc8e 
Add possibility to setup SSD16XX_CMD_UPDATE_CTRL1 register

Signed-off-by: Korneliusz Osmenda <[email protected]>
@korneliuszo @stephanosio
drivers: display:SSD16XX: dtb binding for data mode 2
0e4403b 
Add possibility to use data mode 2

Signed-off-by: Korneliusz Osmenda <[email protected]>
@korneliuszo @stephanosio
drivers: display:SSD16XX: dtb binding for SSD16XX_CMD_OTP_SELECTION_CTRL
39fee55 
Add possibility to setup SSD16XX_CMD_OTP_SELECTION_CTRL register

Signed-off-by: Korneliusz Osmenda <[email protected]>
@stephanosio
Copy link
Member

stephanosio commented Aug 31, 2022

Rebased to fix CI failure

@carlescufi
Copy link
Member

carlescufi commented Sep 1, 2022

@galak @gmarull @mbolivar-nordic could you take a look?

jfischer-no
jfischer-no requested changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@jfischer-no jfischer-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit title should be like: "drivers: ssd16xx: ..."
Commit messages still not explain the reason for the changes.
IIRC, there is work in opposite direction, see #48163

@jfischer-no jfischer-no requested a review from andysan September 2, 2022 09:07
@korneliuszo
Copy link
Author

korneliuszo commented Sep 2, 2022

#48163 looks better than my patchset, rebased needed by me patches on this pull request.

@mbolivar-nordic
Copy link
Contributor

mbolivar-nordic commented Sep 14, 2022

#48163 looks better than my patchset, rebased needed by me patches on this pull request.

So are you going to close this?

@korneliuszo
Copy link
Author

korneliuszo commented Sep 14, 2022

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfischer-no jfischer-no jfischer-no requested changes

@galak galak Awaiting requested review from galak

@gmarull gmarull Awaiting requested review from gmarull

@mbolivar-nordic mbolivar-nordic Awaiting requested review from mbolivar-nordic

@andysan andysan Awaiting requested review from andysan

Assignees

@mbolivar-nordic mbolivar-nordic

Labels

area: Devicetree area: Display

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@korneliuszo @carlescufi @stephanosio @mbolivar-nordic @jfischer-no @zephyrbot