-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Move BOARD_* and SOC_* configuration to unselectable Kconfigs #50154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
2fd575d
soc: arm: nuvoton: Make SOC Kconfig options unselectable
nordicjm a1e7ee2
soc: arm: nxp: Make SOC Kconfig options unselectable
nordicjm 156fc82
soc: arm: quicklogic: Make SOC Kconfig options unselectable
nordicjm 7dfe82d
soc: arm: renesas: Make SOC Kconfig options unselectable
nordicjm fb9dac8
soc: arm: rpi: Make SOC Kconfig options unselectable
nordicjm a1a2707
soc: arm: silabs: Make SOC Kconfig options unselectable
nordicjm e24eb94
soc: arm: st: Make SOC Kconfig options unselectable
nordicjm e23299e
soc: arm: ti: Make SOC Kconfig options unselectable
nordicjm 0e18401
soc: arm: xilinx: Make SOC Kconfig options unselectable
nordicjm ae586d8
soc: arm64: arm: Make SOC Kconfig options unselectable
nordicjm 57e774b
soc: arm64: broadcom: Make SOC Kconfig options unselectable
nordicjm 4d38ccc
soc: arm64: intel: Make SOC Kconfig options unselectable
nordicjm ca658ef
soc: arm64: nxp: Make SOC Kconfig options unselectable
nordicjm 60c6cc3
soc: riscv: ite: Make SOC Kconfig options unselectable
nordicjm 9611db4
soc: riscv: Make SOC Kconfig options unselectable
nordicjm 2829ca4
soc: xtensa: intel: Make SOC Kconfig options unselectable
nordicjm c814d3e
soc: xtensa: nxp: Make SOC Kconfig options unselectable
nordicjm 05178a3
soc: arc: snps: Make SOC Kconfig options unselectable
nordicjm b9d5e38
soc: arm: arm: Make SOC Kconfig options unselectable
nordicjm 8e42385
soc: arm: aspeed: Make SOC Kconfig options unselectable
nordicjm 20f6089
soc: arm: atmel: Make SOC Kconfig options unselectable
nordicjm bcb9c3d
soc: arm: broadcom: Make SOC Kconfig options unselectable
nordicjm 9762be7
soc: arm: cypress: Make SOC Kconfig options unselectable
nordicjm 9080041
soc: arm: gigadevice: Make SOC Kconfig options unselectable
nordicjm af0beb2
soc: arm: infineon: Make SOC Kconfig options unselectable
nordicjm ce8eac0
soc: arm: intel: Make SOC Kconfig options unselectable
nordicjm 8c9b930
soc: arm: microchip: Make SOC Kconfig options unselectable
nordicjm 1c67331
soc: Remove CPU selection from being a choice
nordicjm 09d2926
boards: arc: Use Kconfig files to select SOC
nordicjm 6240913
boards: arm: Use Kconfig files to select SOC
nordicjm a05995f
boards: arm64: Use Kconfig files to select SOC
nordicjm 19af1c2
boards: mips: Use Kconfig files to select SOC
nordicjm b04f90a
boards: nios2: Use Kconfig files to select SOC
nordicjm 830bc72
boards: posix: Use Kconfig files to select SOC
nordicjm ffcdd48
boards: riscv: Use Kconfig files to select SOC
nordicjm 5aaaa8d
boards: sparc: Use Kconfig files to select SOC
nordicjm 42c8847
boards: x86: Use Kconfig files to select SOC
nordicjm ddc71d4
boards: xtensa: Use Kconfig files to select SOC
nordicjm 770ca00
Kconfig: Load specific board Kconfig
nordicjm d26ca90
soc: arm: nordic: Make SOC Kconfig options unselectable
nordicjm e47f704
kconfig: Make board Kconfig.defconfig optional
nordicjm ad63f62
drivers: Add native_posix_64 to depends on list
nordicjm ce80629
drivers: Change xenvm to use SOC instead of BOARD Kconfig
nordicjm 0ae0d9b
boards: arm: remove setting BOARD Kconfig
nordicjm d665d21
testsuide: boards: unit_testing: Update Kconfig file name
nordicjm e7c7e31
drivers: Update for x86 Kconfig changes
nordicjm 0bcd73e
modules: tfm: Update board names
nordicjm e188c8d
tests: Update native_posix ifdef checks
nordicjm 961d493
rtio: Update native_posix ifdef check
nordicjm 3410863
samples: net: socketpair: Update native_posix ifdef check
nordicjm 4ad3d61
bluetooth: Update native_posix ifdef check
nordicjm 325ed59
doc: Add board environment variable
nordicjm f6f6a55
samples: tfm: psa_firmware: Update mps3_an547 board name
nordicjm 7188ad1
modules: tfm: Update nxp Kconfig check
nordicjm 62de78d
lib: posix: Update board name
nordicjm 056a38e
tests: kernel: mem_protect: Update nsim ifdef check
nordicjm 17b2b20
samples: board: arc_secure_services: Do not force board
nordicjm 6dff5fd
tests: ztest: error_hook: Update QEMU ifdef checks
nordicjm 580d0a7
boards: arc: remove setting BOARD Kconfig
nordicjm 534e5a7
boards: mips: remove setting BOARD Kconfig
nordicjm 68d4a1f
boards: nios2: remove setting BOARD Kconfig
nordicjm f5790ee
boards: posix: remove setting BOARD Kconfig
nordicjm 018680f
boards: riscv: remove setting BOARD Kconfig
nordicjm 8a180a5
boards: sparc: remove setting BOARD Kconfig
nordicjm beed5a4
boards: x86: remove setting BOARD Kconfig
nordicjm 140060b
boards: xtensa: remove setting BOARD Kconfig
nordicjm 687795f
scripts: ci: check_compliance: Add BOARD environmental value
nordicjm da9b0df
boards: arc: Remove if checks for board names
nordicjm 3ee7df5
boards: arm: Remove if checks for board names
nordicjm 7b22013
boards: mips: Remove if checks for board names
nordicjm 0a4f3f5
boards: nios2: Remove if checks for board names
nordicjm 4746a7f
boards: posix: Remove if checks for board names
nordicjm 2aa48ee
boards: riscv: Remove if checks for board names
nordicjm 7179c4c
boards: sparc: Remove if checks for board names
nordicjm f52fa17
boards: x86: Remove if checks for board names
nordicjm b1010f7
boards: xtensa: Remove if checks for board names
nordicjm dae50bb
boards: shields: Remove if checks for board names
nordicjm aaf7dc9
drivers: timer: apic_tsc: Update native_posix ifdef check
nordicjm 13fe183
tests: drivers: adc: adc_api: Update native_posix ifdef check
nordicjm 348fa78
tests: drivers: pwm: pwm_api: Update native_posix ifdef check
nordicjm f71611d
tests: boards: native_posix: cpu_wait: Add native_posix_64 support
nordicjm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_EM_STARTERKIT_R23 | ||
| bool | ||
| default y | ||
| select SOC_EMSK | ||
| select SOC_EMSK_EM9D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_EM_STARTERKIT_R23 | ||
| bool | ||
| default y | ||
| select SOC_EMSK | ||
| select SOC_EMSK_EM11D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_EM_STARTERKIT_R23 | ||
| bool | ||
| default y | ||
| select SOC_EMSK | ||
| select SOC_EMSK_EM7D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_EM_STARTERKIT_R22 | ||
| bool | ||
| default y | ||
| select SOC_EMSK | ||
| select SOC_EMSK_EM7D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_EM_STARTERKIT_R23 | ||
| bool | ||
| default y | ||
| select SOC_EMSK | ||
| select SOC_EMSK_EM9D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_EMSDP | ||
| bool | ||
| default y | ||
| select SOC_ARC_EMSDP | ||
| select SOC_EMSDP_EM11D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_EMSDP_EM4 | ||
| bool | ||
| default y | ||
| select SOC_ARC_EMSDP | ||
| select SOC_EMSDP_EM4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_EMSDP_EM5D | ||
| bool | ||
| default y | ||
| select SOC_ARC_EMSDP | ||
| select SOC_EMSDP_EM5D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_EMSDP_EM6 | ||
| bool | ||
| default y | ||
| select SOC_ARC_EMSDP | ||
| select SOC_EMSDP_EM6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_EMSDP_EM7D | ||
| bool | ||
| default y | ||
| select SOC_ARC_EMSDP | ||
| select SOC_EMSDP_EM7D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_EMSDP_EM7D_ESP | ||
| bool | ||
| default y | ||
| select SOC_ARC_EMSDP | ||
| select SOC_EMSDP_EM7D_ESP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_EMSDP_EM9D | ||
| bool | ||
| default y | ||
| select SOC_ARC_EMSDP | ||
| select SOC_EMSDP_EM9D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_HSDK | ||
| bool | ||
| default y | ||
| select SOC_ARC_HSDK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Copyright (c) 2022 Zephyr Project members and individual contributors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config BOARD_HSDK_2CORES | ||
| bool | ||
| default y | ||
| select SOC_ARC_HSDK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this effectively changes
Kconfig.defconfigfrom being mandatory to being optional.The alternative approach is to keep the
sourceand then boards not having any default to override must create an empty file, maybe containing# Intentionally left empty.I have a slight preference for keeping the
sourceand then an empty file for those boards not needing to override anything.Reason being:
sourcehelps them to place board specific defconfigs the right place.kconfig.defconfig/Kconfig.defconfinstead ofKconfig.defconfig.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer we use
osource, we shouldn't create empty files if they aren't needed. I get the points you make, but there are enough boards that will have a Kconfig.defconfig that custom boards can see what the pattern is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough, we have different opinion on this.
Another risk is that someone later wants to add a new
defaultto a board which doesn't have aKconfig.defconfigalready.Contributor looks around in that board folder and decides to place it in
Kconfig.$(BOARD)because lack of knowledge.Such PR can easily approved and be merged, resulting in inconsistency.
Whereas a
Kconfig.defconfigwith content:will help to ensure that such defaults goes to the right location.
Contributors will often look for an existing file to place small suggestions, rather than create new files.