Nrf52 adopt soc scheme v2 compliance failure #50356
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not review this commit. Signed-off-by: Torsten Rasmussen <[email protected]>
This commit adopts SoC v2 to nRF52 SoC series. This ensures that when Board scheme v2 is used for an nRF52 SoC series, then all SoC selection is handled internally by Kconfig, and no selection / re-configuration is possible by end-user / through configuration files. SoC Scheme v1 is still supported for backward compatibility. The SoC scheme v1 defines a choice menu, into which the SoC config entries must be injected. This is done through the existing `soc/arm/nordic_nrf/Kconfig.soc`. SoC scheme v2 uses promptless entries, and in order to share the same Kconfig.series files, then prompt is made conditional. SoC scheme v2 requires the SoC to be self-contained, that is no references are allowed out-side the SoC Kconfig tree. To support both v1 and v2 scheme, then SoC names have been moved from defconfigs into Kconfig.soc.names, and a Kconfig.soc.common with high level nRF SoC identifiers. This allow tp share those settings between both schemes. To avoid visible prompts for nRF51, nRF53, and nRF91 series, when loaded into SoC scheme v2, then the prompt has been made conditional. Signed-off-by: Torsten Rasmussen <[email protected]>
This commit updates nrf52840dk_nrf52840 to use board scheme v2, and thereby remove the Kconfig BOARD setting, as this is now passed from CMake. It also uses the new SoC approach, and thereby ensuring that the right SoC is always used, and cannot accidentially be changed by the user. Signed-off-by: Torsten Rasmussen <[email protected]>
This commit updates nrf52840dk_nrf52811 to use board scheme v2, and thereby remove the Kconfig BOARD setting, as this is now passed from CMake. It also uses the new SoC approach, and thereby ensuring that the right SoC is always used, and cannot accidentially be changed by the user. Signed-off-by: Torsten Rasmussen <[email protected]>
This commit is intended to verify the github action check_compliance actually fails when a new v2 board contains references outside the tree. In this case, `select NATIVE_APPLICATION`. Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand
force-pushed
the
nrf52_adopt_soc_scheme_v2_compliance_failure
branch
from
f9a28bf to
0f649db
Compare
5 tasks
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Contributor
Contributor
@tejlmand do you need to take these patches into this PR? Confused about status |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to verify that a board v2 not conforming to rules will fail compliance.
See #50305 for details.