drivers: adc: sam0: Add support for C2x #50388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benys
requested review from
MaureenHelm,
anangl,
galak and
ioannisg
as code owners
zephyrbot
added
area: ADC
nandojve
changed the title
Member
|
Hi @benys , You need make CI happy. Add CC: @attie-argentum , @lucasssvaz |
Member
attie-argentum
left a comment
attie-argentum
left a comment
There was a problem hiding this comment.
Otherwise, LGTM, thanks for the PR!
|
Besides what @attie-argentum noted, looks good. |
benys
force-pushed
the
fix_compliation_adc_for_sam0
branch
2 times, most recently
from
bff9692 to
654560c
Compare
Contributor
Author
|
@attie-argentum I hope that I fix your issues;) |
attie-argentum
suggested changes
Oct 7, 2022
benys
force-pushed
the
fix_compliation_adc_for_sam0
branch
from
654560c to
c340c10
Compare
Contributor
Author
|
I hope that it is now fine :) |
C21 doesn't have ADC_REFCTRL_REFSEL_AREFB and have different APBs. Signed-off-by: Kamil Serwus <[email protected]>
benys
force-pushed
the
fix_compliation_adc_for_sam0
branch
from
c340c10 to
8bb532e
Compare
nandojve
approved these changes
Oct 22, 2022
teburd
approved these changes
Oct 25, 2022
stephanosio
approved these changes
Oct 25, 2022
Comment on lines
+109
to
+118
| * The following MCLK clock configuration fix-up symbols map to the applicable | ||
| * APB-specific symbols, in order to accommodate different SoC series with the | ||
| * ADC core connected to different APBs. | ||
| */ | ||
| #if defined(MCLK_APBDMASK_ADC) || defined(MCLK_APBDMASK_ADC0) | ||
| # define MCLK_ADC (MCLK->APBDMASK.reg) | ||
| #elif defined(MCLK_APBCMASK_ADC0) | ||
| # define MCLK_ADC (MCLK->APBCMASK.reg) | ||
| #else | ||
| # error ADC not supported... |
Contributor
There was a problem hiding this comment.
Why can't this be supported in devicetree?
Contributor
Author
There was a problem hiding this comment.
At SAM MCU clock connection to ADC module is located in some processor in ABPD registry and some at APBC.
I don't find any usage at devicetree to set / get valid registry.
SAM Drives uses constraints from ASF headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #50384 this is fix for compilations for SAMs
C21 doesn't have ADC_REFCTRL_REFSEL_AREFB and have different APBs
Signed-off-by: Kamil Serwus [email protected]