drivers: Disallow FD frames when not in FD Mode for mcan #50769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThadHouse
requested review from
alexanderwachter and
henrikbrixandersen
as code owners
|
Yeah. We need to fix this in pretty much every driver. |
henrikbrixandersen
requested changes
Sep 28, 2022
Currently, if you send an FD frame with the mcan driver, but FD mode was not enabled, the hardware will only send the first 8 bytes of the frame, but still with a DLC of FD length. This results in some very weird behavior on the bus, dependning on what other devices are doing. Add a check to ensure an FD send only occurs with FD enabled. Signed-off-by: Thad House <[email protected]>
ThadHouse
force-pushed
the
thadhouse/canfdsend
branch
from
5b89435 to
5111118
Compare
alexanderwachter
approved these changes
Sep 28, 2022
|
@ThadHouse Can I ask you to open a bug report for this one as well? Thanks. |
Done. #50776 |
henrikbrixandersen
added
bug
henrikbrixandersen
approved these changes
Sep 28, 2022
str4t0m
approved these changes
Sep 28, 2022
|
@henrikbrixandersen, is this needed for 3.2 release? |
henrikbrixandersen
requested changes
Sep 29, 2022
Alternate proposal in #51361. |
|
@ThadHouse Thank you for submitting this. However, an alternate solution to this issue was merged in #51361, so I am closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you send an FD frame with the mcan driver, but FD mode was not enabled, the hardware will only send the first 8 bytes of the frame, but still with a DLC of FD length. This results in some very weird behavior on the bus, dependning on what other devices are doing. Add a check to ensure an FD send only occurs with FD enabled.
Fixes: #50776
Signed-off-by: Thad House [email protected]