Skip to content

drivers: Disallow FD frames when not in FD Mode for mcan #50769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

drivers: Disallow FD frames when not in FD Mode for mcan #50769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions drivers/can/can_mcan.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,6 +841,16 @@ int can_mcan_send(const struct device *dev,
return -ENETUNREACH;
}

if (frame->fd && (can->cccr & CAN_MCAN_CCCR_FDOE) == 0) {
LOG_ERR("fd flag set without fd mode enabled.");
return -EINVAL;
}

if (frame->brs && (can->cccr & CAN_MCAN_CCCR_BRSE) == 0) {
LOG_ERR("brs flag set without fd brs mode enabled.");
return -EINVAL;
}

ret = k_sem_take(&data->tx_sem, timeout);
if (ret != 0) {
return -EAGAIN;
Expand Down