drivers: sensor: Add ROHM BH1750 driver

[gportay]

Dear Maintainers,

This is my first driver, and I wonder if you are interested in having it upstream.

The sensor has several working modes, and I have picked up the mode "one-time high resolution mode"; there are also five other modes that I can implement (including low resolution, continuous...). Do you want I implement all of them?

I have also a sample code, tell me if it needs to be part of the PR.

The code is based on the Bosch BME280 source code.

Kind Regards,
Gaël

---

This adds support for ROHM BH1750 the i2c light sensor.

Signed-off-by: Gaël PORTAY [email protected]

[MaureenHelm]

This is my first driver, and I wonder if you are interested in having it upstream.

Yes, thank you for the contribution!

The sensor has several working modes, and I have picked up the mode "one-time high resolution mode"; there are also five other modes that I can implement (including low resolution, continuous...). Do you want I implement all of them?

It's not required. If you want to add them, please do that in a follow up PR after this PR gets merged.

I have also a sample code, tell me if it needs to be part of the PR.

We are trying to reduce the number of driver-specific samples. If you're interested in helping create a generic light sensor sample similar to samples/sensor/accel_polling/ and samples/sensor/magn_polling/ and enabling the sample for this sensor, it would be a welcome addition.

The code is based on the Bosch BME280 source code.

If you've copied code from somewhere, please keep the original copyright and add your own copyright in a new line.

Please add this sensor tests/drivers/build_all/sensor to ensure the driver gets built in CI

[MaureenHelm]

Looks good overall, thank you.

Please review and address the failed twister checks.

[MaureenHelm]

Please review and address the failed twister checks.

This still needs to be addressed

[gportay]

@MaureenHelm: as for 51269

You don't need floating point math for this

do you prefer the former solution with long long unsigned?

static int bh1750_channel_get(const struct device *dev,
			      enum sensor_channel chan,
			      struct sensor_value *val)
{
	struct bh1750_data *data = dev->data;
	long long unsigned tmp;

	switch (chan) {
	case SENSOR_CHAN_LIGHT:
		tmp = 1000000UL * data->raw_val / 1.2;
		val->val1 = tmp / 1000000;
		val->val2 = tmp % 1000000;
		break;
	default:
		return -EINVAL;
	}

	return 0;
}

[gportay]

@MaureenHelm do you want me to switch back to long long unsigned for that driver as well?

[gportay]

@MaureenHelm ping?

[gportay]

I am closing the MR, since another driver for this hardware was merged in #43086.