Skip to content

Conversation

@mbolivar-nordic
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic commented Nov 15, 2022

Fix comments in board DTS files referring to AN521 tables defining memory areas, and choose node label names that more accurately reflect the entries of interest in those tables.

@microbuilder this reflects the first couple of things we talked about. I thought about how to plumb the cpu1 start address from DT all the way through, but I think that's going to require system devicetree. It's an interesting use case that I hadn't considered, though, and will definitely affect the design.

@microbuilder
Copy link
Member

Fix comments in board DTS files referring to AN521 tables defining memory areas, and choose node label names that more accurately reflect the entries of interest in those tables.

@ktown this reflects the first couple of things we talked about. I thought about how to plumb the cpu1 start address from DT all the way through, but I think that's going to require system devicetree. It's an interesting use case that I hadn't considered, though, and will definitely affect the design.

I think you're looking for @microbuilder sorry (terrible name from a company I ran lifetimes ago). I'm sure someone is very confused about who you are and what you're tagging them for. 😉

@mbolivar-nordic mbolivar-nordic force-pushed the mps2-an521-ram-improvements branch from 4573d58 to d679480 Compare November 15, 2022 14:41
@mbolivar-nordic
Copy link
Contributor Author

@microbuilder my mistake on the username :). Sorry for confusion; I was on autopilot and used your discord handle.

Suggestions applied, thanks. I expect I'll have a system DT demo for this board by end of day.

@mbolivar-nordic mbolivar-nordic force-pushed the mps2-an521-ram-improvements branch from d679480 to ad4310e Compare November 15, 2022 16:13
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jan 15, 2023
@github-actions github-actions bot closed this Jan 29, 2023
@mbolivar-nordic mbolivar-nordic force-pushed the mps2-an521-ram-improvements branch from ad4310e to 2399084 Compare January 30, 2023 17:47
@mbolivar-nordic
Copy link
Contributor Author

Rebased with no changes to see if twister passes this time

Fix comments in board DTS files referring to AN521 tables defining
memory areas, and choose node label names that more accurately reflect
the entries of interest in those tables.

Adjust the one in-tree user of the affected node labels.

Signed-off-by: Martí Bolívar <[email protected]>
@github-actions github-actions bot removed the Stale label Jan 31, 2023
@stephanosio stephanosio added this to the v3.4.0 milestone Feb 1, 2023
@nashif nashif merged commit 20c5866 into zephyrproject-rtos:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants