Skip to content

zdsp: Add ARC DSPLIB backend for zdsp #52478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2023
Merged

zdsp: Add ARC DSPLIB backend for zdsp #52478

merged 3 commits into from
Feb 21, 2023

Conversation

@SiyuanCheng-CN
Copy link
Member

@SiyuanCheng-CN SiyuanCheng-CN commented Nov 22, 2022 •
edited
Loading

Introduce ARC DSPLIB backend zdsp library for ARC target.
Add __agu to map with ARC DSPLIB
Add basicmath tests for ARC backend

@zephyrbot
Copy link

zephyrbot commented Nov 22, 2022

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
cmsis zephyrproject-rtos/cmsis@093de61 zephyrproject-rtos/cmsis@74981bf (master) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@SiyuanCheng-CN SiyuanCheng-CN mentioned this pull request Nov 22, 2022
Merged
@SiyuanCheng-CN SiyuanCheng-CN changed the title Add ARC DSPLIB backend for zdsp zdsp: Add ARC DSPLIB backend for zdsp Nov 23, 2022
@SiyuanCheng-CN SiyuanCheng-CN force-pushed the siyuan-dsplib branch 3 times, most recently from 4dd6a34 to f404a8a Compare December 12, 2022 08:06
@SiyuanCheng-CN SiyuanCheng-CN marked this pull request as ready for review December 12, 2022 08:07
@zephyrbot zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding area: Kernel platform: Synopsys Synopsys area: DSP labels Dec 12, 2022
ruuddw
ruuddw previously approved these changes Jan 30, 2023
View reviewed changes
@evgeniy-paltsev evgeniy-paltsev self-requested a review January 30, 2023 09:35
abrodkin
abrodkin previously approved these changes Jan 30, 2023
View reviewed changes
@stephanosio stephanosio added the TSC Topics that need TSC discussion label Jan 30, 2023
@stephanosio
Copy link
Member

stephanosio commented Jan 30, 2023

@stephanosio unfortunately @SiyuanCheng-CN is away this week due to a New Year holiday in China so very unlikely we'll be able to address your comments this week so that the PR is merged before the upcoming feature freeze (I guess it happens later this week). I'm wondering if there's a chance to get it merged as an exclusion (given its scope and current state of the review) a bit later once @SiyuanCheng-CN is back next week?

@abrodkin Since this PR is fairly self-contained, I have no objection to making this an exception; but, that will need to be approved by the TSC as per the documented process. I will briefly mention this during the TSC meeting this week; but, I cannot make any guarantees on whether an exception will be granted.

stephanosio
stephanosio previously approved these changes Jan 30, 2023
View reviewed changes
@abrodkin
Copy link
Contributor

abrodkin commented Jan 30, 2023

@stephanosio there's no pressure for this PR and we may easily get it into the next release, it was more of an attempt to work-around a bit unfortunate timeline.

@stephanosio stephanosio modified the milestones: v3.3.0, v3.4.0 Feb 7, 2023
@nashif nashif removed the TSC Topics that need TSC discussion label Feb 8, 2023
yperess
yperess previously approved these changes Feb 8, 2023
View reviewed changes
@fabiobaltieri
Copy link
Member

fabiobaltieri commented Feb 20, 2023

@SiyuanCheng-CN can you rebase please?

@carlescufi
Copy link
Member

carlescufi commented Feb 20, 2023

@SiyuanCheng-CN please rebase and solve the conflict

Siyuan Cheng added 3 commits February 20, 2023 16:57
zdsp: Introduce attribute marco for third-party backend
5ea2043 
Introduce DSP_DATA and DSP_STATIC_DATA attribute marco
to support third-party backend

Signed-off-by: Siyuan Cheng <[email protected]>
zdsp: add ARC DSPLIB backend for zdsp
0694bd0 
Introduce ARC DSPLIB backend zdsp library for ARC target.
Add agu and restrict attributes to map with ARC DSPLIB

Signed-off-by: Siyuan Cheng <[email protected]>
zdsp: add in-place operaton test for basicmath
be23d57 
Add in-place calculatoin test for every functions in basicmath

Signed-off-by: Siyuan Cheng <[email protected]>
@SiyuanCheng-CN
Copy link
Member Author

SiyuanCheng-CN commented Feb 20, 2023

@fabiobaltieri @carlescufi Already rebased, thx

@stephanosio stephanosio requested a review from yperess February 20, 2023 12:50
yperess
yperess reviewed Feb 21, 2023
View reviewed changes
subsys/dsp/Kconfig
choice DSP_BACKEND
prompt "DSP library backend selection"
default DSP_BACKEND_CMSIS if CMSIS_DSP
default DSP_BACKEND_ARCMWDT if ARC && "$(ZEPHYR_TOOLCHAIN_VARIANT)" = "arcmwdt"
Copy link
Contributor

@yperess yperess Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest moving this up one line so we choose the right optimized default (feel free to do this in another PR in order to avoid getting another round of reviews).

@carlescufi carlescufi merged commit f874ba2 into zephyrproject-rtos:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abrodkin abrodkin abrodkin approved these changes

@yperess yperess yperess approved these changes

@stephanosio stephanosio stephanosio approved these changes

@ruuddw ruuddw ruuddw left review comments

@MaureenHelm MaureenHelm MaureenHelm left review comments

@evgeniy-paltsev evgeniy-paltsev evgeniy-paltsev left review comments

@nashif nashif Awaiting requested review from nashif

@dcpleung dcpleung Awaiting requested review from dcpleung

@andyross andyross Awaiting requested review from andyross

@carlescufi carlescufi Awaiting requested review from carlescufi

@galak galak Awaiting requested review from galak

@ceolin ceolin Awaiting requested review from ceolin

@microbuilder microbuilder Awaiting requested review from microbuilder

@peter-mitsis peter-mitsis Awaiting requested review from peter-mitsis

@povergoing povergoing Awaiting requested review from povergoing

Assignees

@stephanosio stephanosio

Labels

area: ARC ARC Architecture area: CMSIS-DSP area: Devicetree Binding PR modifies or adds a Device Tree binding area: DSP area: Kernel manifest manifest-cmsis platform: Synopsys Synopsys

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.