Boards: arm: gd32a503v_eval: introduce gd32a503v_eval board

[feilongfl]

introduce gd32a503v_eval board

This is Gigadevice's first automotive chip with similar peripheral IP to STM32 or GD32.

due to the following requirement of the ECC memory:

I enabled CONFIG_PLATFORM_SPECIFIC_INIT and implement z_arm_platform_init function in soc.c to clear all memory in da51427 . Without clear memory, it will fall into ecc nmi exception after power off reboot.
I'm not sure if there is a better way to implement it.I split it from the soc implementation for review purposes.

---

todo:

• add documents for this board
• enable and test other gd32 peripheral
  • pinctrl & gpio
  • rcu
  • USART
  • dac
  • WDT
  • adc
  • SPI

About the IIC driver:
This SOC use a different IP, it changes a lot, so I decided not to implement it in this PR

---

other gigadevice works:
#38657

[zephyrbot]

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_gigadevice	zephyrproject-rtos/hal_gigadevice@024ed9e	zephyrproject-rtos/hal_gigadevice@2994b7d (main)	zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

[feilongfl]

@cameled

About FMC, I've checked #42809 , and I think gd32a50x series use GD32 FMC v2, can you confirm if it is correct?

---

gigadevice manual

[cameled]

@cameled

About FMC, I've checked #42809 , and I think gd32a50x series use GD32 FMC v2, can you confirm if it is correct?

gigadevice manual

Yes, it is.

[nandojve]

Two things to take in consideration:

1. Is it valuable check if zephyr,sram would be better option.
2. Is it possible to use memset ?

[feilongfl]

Is it valuable check if zephyr,sram would be better option.

fixed

Is it possible to use memset ?

I’ve tried this, and got NMI exception at startup.

void z_arm_platform_init(void)
{
	memset((void *)DT_REG_ADDR(DT_INST(0, SRAM)), 0, DT_REG_SIZE(DT_INST(0, SRAM)));
}

I think the reason is memset store data by char, but memory want written in 32bit.

void *memset(void *buf, int c, size_t n)
{
	unsigned char *d_byte = (unsigned char *)buf;
	unsigned char c_byte = (unsigned char)c;
              /* ...... */
	while (n > 0) {
		*(d_byte++) = c_byte;
		n--;
	}

	return buf;
}

[nandojve]

Hi @feilongfl ,

In general you are doing a very good work. However, you need reorder you commits sequence as:

1. update hal
2. DTS
3. introduce SoC
4. drivers
   4.1) driver DTS
   4.2) drive itself
   4.3) driver tests
5. board
6. samples

Why? If you look drivers: pinctrl: gd32: add gd32a50x support it requires a CONFIG_SOC_SERIES_GD32A50X which is defined later at soc: gd32a50x: introduce gd32a50x soc series. This is an inconsistent on the PR sequence that we need avoid.

I'll wait you reorder the PR sequence to start review : )

[nandojve]

Hi @feilongfl ,

Please squash following commits:

1. Below 3 as soc: gd32a50x: introduce gd32a50x soc series
   modules: hal_gigadevice: add defintions for GD32A50X
   soc: gd32a50x: introduce gd32a50x soc series
   soc: gd32a50x: clear ecc memory when system start
2. Below 2 as drivers: pinctrl: gd32: add gd32a50x support
   include: pinctrl: gd32: add gd32a50x support
   drivers: pinctrl: gd32: add gd32a50x support

[nandojve]

Hi @feilongfl ,

Please, rebase and fix conflict. After that update west.yml with new hash from hal.

[cameled]

LGTM, thanks @feilongfl !

[nandojve]

Good work @feilongfl !

[gmarull]

Note: this was merged adding binaries (cmsis-packs) to the module. I don't think this is acceptable, nor Zephyr's responsability, to host CMSIS packs. Please send a PR removing that from upstream Zephyr.

[gmarull]

too late, but why doesn't board enable GPIO, as per-policy? this would not be needed at all.

[feilongfl]

Sorry, I didn't know about this policy before.
Are all boards supposed to have the following peripherals enabled by default?

CONFIG_CONSOLE=y
CONFIG_UART_CONSOLE=y
CONFIG_SERIAL=y

CONFIG_GPIO=y

Is there anything else I missed?

[gmarull]

Yes, in general GPIO/UART are considered "minimal peripherals" used by lots of samples.