Add Microchip XEC BBLED PWM driver #52807
Conversation
jvasanth1
requested review from
albertofloyd,
galak and
nashif
as code owners
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
VenkatKotakonda,
anangl and
henrikbrixandersen
jvasanth1
force-pushed
the
xec_bbled_pwm_pr
branch
2 times, most recently
from
d986cca to
40e5efa
Compare
|
@albertofloyd can you help to review |
|
@galak can you help to review? |
henrikbrixandersen
left a comment
henrikbrixandersen
left a comment
There was a problem hiding this comment.
The driver and bindings look good, but perhaps a dedicated sample for a simple PWM LED driver is too much?
The dedicated sample is part of samples/boards/mec172xevb_assy6906 |
|
@henrikbrixandersen can you help to approve? |
henrikbrixandersen
left a comment
henrikbrixandersen
left a comment
There was a problem hiding this comment.
The driver and bindings look good, but perhaps a dedicated sample for a simple PWM LED driver is too much?
The dedicated sample is part of samples/boards/mec172xevb_assy6906
I can see that. I still see no value added by a board specific PWM LED sample. We have a couple of PWM LED samples under samples/basic/ already. Any reason why this particular PWM LED cannot work with those samples?
okay, will remove the board specific PWM LED sample. |
jvasanth1
force-pushed
the
xec_bbled_pwm_pr
branch
from
40e5efa to
155ba14
Compare
jvasanth1
force-pushed
the
xec_bbled_pwm_pr
branch
from
155ba14 to
70b9b13
Compare
The Microchip XEC (MEC172x and MEC152x) have a breathing-blinking LED (BBLED) block which implements a simple PWM mode. The BBLED PWM frequencies are 32KHz and 48MHz selectable in device tree. Frequency divider is 12-bit resolution from 256 to (256 * 4096). Signed-off-by: Jay Vasanth <[email protected]>
|
@henrikbrixandersen can you help to approve? |
|
@albertofloyd can you help to re-approve? |
7 participants
The Microchip XEC (MEC172x and MEC152x) have a breathing-blinking LED (BBLED) block which implements a simple PWM mode. This PR adds pwm_mchp_xec_bbled driver to operate the bbled as pwms.