scripts: dts: Skip empty yaml files #53710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@allannk you will need to fix your commit message, see here: |
Contributor
|
@allannk please consider also watching this short video on how to get your patches merged: https://www.youtube.com/watch?v=mnVNLM7ynMQ |
galak
previously approved these changes
Feb 9, 2023
Contributor
|
@mbolivar-nordic take another look |
mbolivar-nordic
previously approved these changes
Feb 9, 2023
henrikbrixandersen
previously approved these changes
Feb 10, 2023
The YAML parsing will currently return a None-type if no input data is empty, and the subsequent check for a substring will cause an exception. Signed-off-by: Allan Norgaard <[email protected]>
stephanosio
dismissed stale reviews from henrikbrixandersen, mbolivar-nordic, and galak
via
ef29f7a
mbolivar-nordic
approved these changes
Feb 13, 2023
Contributor
mbolivar-nordic
left a comment
mbolivar-nordic
left a comment
There was a problem hiding this comment.
@allannk now that this PR has green CI, please do not push into it again. Every time you push, we have to re-approve. Thanks!
henrikbrixandersen
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving an empty yaml file in any DTS_ROOT included directories will currently crash the script
dts/gen_driver_kconfig_dts.py. Added a check to skip any empty files, like it is already skipping unparsable files and files without acompatiblefield.Fixes: #54683