Add support Rohm bh1750 ambient light sensor

[jeronimoagullo]

Product Homepage:

https://www.rohm.com/

DataSheet:
https://www.farnell.com/datasheets/1813320.pdf

Testing Environment:
STMicroelectronics B_L4S5I_IOT01A Discovery kit

Signed-off-by: Jeronimo Agullo Ocampos [email protected]

[galak]

DT binding looks ok.

[MaureenHelm]

Thank you for the contribution!

Please add this sensor to tests/drivers/build_all/sensor to ensure it builds in CI, and also address requested changes by amending your comments and force pushing.

[MaureenHelm]

Please implement requested changes by amending the original commit rather than adding new commits. You also need to rebase to resolve merge conflicts.

[jeronimoagullo]

Please implement requested changes by amending the original commit rather than adding new commits. You also need to rebase to resolve merge conflicts.

I have added the modifitions according to comments and then stashed all commits into the original commit. Then, I have merge, however, the merge has provoked a new commit. I am not sure if it is rigth, may you confirm it? Thank you in advance

[MaureenHelm]

Please implement requested changes by amending the original commit rather than adding new commits. You also need to rebase to resolve merge conflicts.

I have added the modifitions according to comments and then stashed all commits into the original commit. Then, I have merge, however, the merge has provoked a new commit. I am not sure if it is rigth, may you confirm it? Thank you in advance

No, you need to rebase on the command line, not in the GH web interface, to remove the merge commit

[jeronimoagullo]

Please implement requested changes by amending the original commit rather than adding new commits. You also need to rebase to resolve merge conflicts.

I have added the modifitions according to comments and then stashed all commits into the original commit. Then, I have merge, however, the merge has provoked a new commit. I am not sure if it is rigth, may you confirm it? Thank you in advance

No, you need to rebase on the command line, not in the GH web interface, to remove the merge commit

Ok, I understood. I think that it is now correct. It has passed all automated tests. Please, check it out. Thank you.

[MaureenHelm]

Please set the address to 0x55 to make it sequential. Note this is a build test that will never run on real hardware

[jeronimoagullo]

Ok, I see it. However, the previous one test_i2c_as5600 is incorrect and should be 64 to follow the correct numbering. Thus, I propose to set the test_i2c_bh1750 address to 0x65.

[jeronimoagullo]

Hi @MaureenHelm and @teburd, it's some days since my latest changes and it passed all tests, I would like to know if something else is missing from my side. Thank you in advance.

[MaureenHelm]

Hi @MaureenHelm and @teburd, it's some days since my latest changes and it passed all tests, I would like to know if something else is missing from my side. Thank you in advance.

We're currently in feature freeze and need to wait until the merge window reopens after the release.
https://github.com/zephyrproject-rtos/zephyr/wiki/Release-Management

[fabiobaltieri]

@jeronimoagullo can you rebase please?

[jeronimoagullo]

@jeronimoagullo can you rebase please?

I have just rebased and pushed. I have merged my contribution with the commit of same sensor with which it was conflicting

[carlescufi]

@jeronimoagullo can you fix the compliance checks:

TRAILING_WHITESPACE: trailing whitespace
26
File:drivers/sensor/bh1750/bh1750.c
27
Line:132
28
 SPACING: space required after that ',' (ctx:VxV)
29
File:drivers/sensor/bh1750/bh1750.c
30
Line:138
31
 SPACING: space required after that ',' (ctx:VxV)
32
File:drivers/sensor/bh1750/bh1750.c
33
Line:138
34
 SPACING: space required after that ',' (ctx:VxV)
35
File:drivers/sensor/bh1750/bh1750.c
36
Line:139
37
 SPACING: space required after that ',' (ctx:VxV)
38
File:drivers/sensor/bh1750/bh1750.c
39
Line:144
40
 TRAILING_WHITESPACE: trailing whitespace
41
File:drivers/sensor/bh1750/bh1750.c
[42](https://github.com/zephyrproject-rtos/zephyr/actions/runs/4295302648/jobs/7498324895#step:9:43)
Line:148
[43](https://github.com/zephyrproject-rtos/zephyr/actions/runs/4295302648/jobs/7498324895#step:9:44)
Error: Process completed with exit code 1.

[jeronimoagullo]

@jeronimoagullo can you fix the compliance checks:

TRAILING_WHITESPACE: trailing whitespace
26
File:drivers/sensor/bh1750/bh1750.c
27
Line:132
28
 SPACING: space required after that ',' (ctx:VxV)
29
File:drivers/sensor/bh1750/bh1750.c
30
Line:138
31
 SPACING: space required after that ',' (ctx:VxV)
32
File:drivers/sensor/bh1750/bh1750.c
33
Line:138
34
 SPACING: space required after that ',' (ctx:VxV)
35
File:drivers/sensor/bh1750/bh1750.c
36
Line:139
37
 SPACING: space required after that ',' (ctx:VxV)
38
File:drivers/sensor/bh1750/bh1750.c
39
Line:144
40
 TRAILING_WHITESPACE: trailing whitespace
41
File:drivers/sensor/bh1750/bh1750.c
[42](https://github.com/zephyrproject-rtos/zephyr/actions/runs/4295302648/jobs/7498324895#step:9:43)
Line:148
[43](https://github.com/zephyrproject-rtos/zephyr/actions/runs/4295302648/jobs/7498324895#step:9:44)
Error: Process completed with exit code 1.

Thank you for your comments, it's now done.

[MaureenHelm]

sensor: Rohm bh1750 ambient light sensor

Update Rohm bh1750 ambient light sensor driver.

Signed-off-by: Jeronimo Agullo <[email protected]>

Please explain why you are updating the driver in the commit message.

[MaureenHelm]

You haven't made any changes to this file; don't add your copyright.

[MaureenHelm]

This could benefit from a more meaningful name, something like MEASUREMENT_MODE

[github-actions]

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.