Skip to content

pytest: Fix typo and add logging #54027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2023
Merged

pytest: Fix typo and add logging #54027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc10f16
pytest: Fix typo in comment in pytest suite
Jan 19, 2023
1341166
pytest: Log pytest command
Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/subsys/testsuite/pytest/pytest/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import pytest

# add option "--comdopt" to pytest, or it will report "unknown option"
# add option "--cmdopt" to pytest, or it will report "unknown option"
# this option is passed from twister.
def pytest_addoption(parser):
parser.addoption(
Expand Down
4 changes: 4 additions & 0 deletions scripts/pylib/twister/twisterlib/harness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import re
import os
import subprocess
import shlex
from collections import OrderedDict
import xml.etree.ElementTree as ET
import logging
Expand Down Expand Up @@ -207,6 +208,9 @@ def pytest_run(self, log_file):
outs = []
errs = []

logger.debug(
"Running pytest command: %s",
" ".join(shlex.quote(a) for a in cmd))
with subprocess.Popen(cmd,
stdout = subprocess.PIPE,
stderr = subprocess.PIPE) as proc:
Expand Down