tests: posix: pthread: init pthread_attr_t on each iteration #57403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test_pthread_descriptor_leak` test was causing a kernel panic on some platforms. Initially, it was not clear why. The usual cases were examined - race conditions, stack sizes, etc. Still no luck. As it turns out, recycling a thread stack (or at least the `pthread_attr_t`) in-place does not work on some platforms, and we need to reinitialize the `pthread_attr_t` and set set the stack property again prior to calling `pthread_create()`. Signed-off-by: Christopher Friedt <[email protected]>
cfriedt
requested review from
dleach02,
hakehuang,
jgl-meta,
keith-packard and
stephanosio
Rather than pass an variable address to a `void *` in `pthread_join()` and do nothing with it, just pass `NULL`. Signed-off-by: Christopher Friedt <[email protected]>
jgl-meta
approved these changes
Apr 29, 2023
cfriedt
deleted the
issues/56163/posix-common-derived-test-fails-on-some-qemu-platforms
branch
cfriedt
added
area: Tests
|
I just thought I should update this PR and say that the change that went in did not actually fix the problem. There is a race condition in between PR #57637 has been drafted with a new testsuite that will allow us to verify the fix with more certainty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_pthread_descriptor_leaktest was causing a kernel panic on some platforms. Initially, it was not clear why.The usual cases were examined - race conditions, stack sizes, etc. Still no luck.
As it turns out, recycling a thread stack (or at least the
pthread_attr_t) in-place does not work on some platforms, and we need to reinitialize thepthread_attr_tand set set the stack property again prior to callingpthread_create().Fixes #56163
Tested with:
west build -p always -b qemu_cortex_r5 -t run tests/posix/common \ -- -DCONFIG_TICKLESS_KERNEL=n -DCONFIG_NEWLIB_LIBC=y