Skip to content

Conversation

@tejlmand
Copy link
Contributor

@tejlmand tejlmand commented Sep 13, 2023

Fixes: #62589
Follow-up: #60031

The PR #60031 moved CMake code to new folder location causing generated library names to change.
This change impacted the use of those libraries in the Zephyr armlink CMake code, causing CMake failures at configure time.

This PR fixes this failure by updating the armlink CMake code to use the new library names.

@tejlmand tejlmand requested a review from nashif as a code owner September 13, 2023 11:54
@tejlmand tejlmand added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Sep 13, 2023
gmarull
gmarull previously approved these changes Sep 13, 2023
SgrrZhf
SgrrZhf previously approved these changes Sep 13, 2023
nordicjm
nordicjm previously approved these changes Sep 13, 2023
57300
57300 previously approved these changes Sep 13, 2023
Copy link
Contributor

@57300 57300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Wrong PR referenced in commit message (60331 -> 60031)

microbuilder
microbuilder previously approved these changes Sep 13, 2023
@tejlmand tejlmand added the DNM This PR should not be merged (Do Not Merge) label Sep 13, 2023
@tejlmand tejlmand force-pushed the 62589_armclang_fixes branch from b3fa879 to 261ef30 Compare September 13, 2023 13:06
@tejlmand tejlmand removed the DNM This PR should not be merged (Do Not Merge) label Sep 13, 2023
Fixes: zephyrproject-rtos#62589
Follow-up: zephyrproject-rtos#60031

The PR zephyrproject-rtos#60031 moved CMake code to new folder location causing generated
library names to change.
This change impacted the use of those libraries in the Zephyr armlink
CMake code, causing CMake failures at configure time.

This PR fixes this failure by updating the armlink CMake code to use
the new library names.

Signed-off-by: Torsten Rasmussen <[email protected]>
@tejlmand tejlmand force-pushed the 62589_armclang_fixes branch from 261ef30 to ef46229 Compare September 13, 2023 13:07
@tejlmand
Copy link
Contributor Author

nit: Wrong PR referenced in commit message (60331 -> 60031)

fixed.

@fabiobaltieri fabiobaltieri merged commit 73605f1 into zephyrproject-rtos:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Build System area: Toolchains Toolchains Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

armclang support broken

8 participants