- 
                Notifications
    
You must be signed in to change notification settings  - Fork 8.2k
 
dfu: boot: mcuboot_shell: Prevent erasing MCUboot/app flash areas #66107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dfu: boot: mcuboot_shell: Prevent erasing MCUboot/app flash areas #66107
Conversation
7ed066d    to
    127b674      
    Compare
  
    Prevents the user from potentially bricking a device by erasing the MCUboot or currently running application flash areas with the mcuboot erase command Signed-off-by: Jamie McCrae <[email protected]>
Adds a note that the shell mcuboot erase command can no longer erase the MCUboot or application slots Signed-off-by: Jamie McCrae <[email protected]>
127b674    to
    7c2b3db      
    Compare
  
    | 
           Hey @nordicjm, sorry to dig up an old PR, but this appears to break in situations when partition manager is in play because the dts specified partitions do not match those in the flash map which is used to perform the erase. As it occurs in my own project the external flash area turns out to be area 1 while the internal active partition is actually area 3. This clashes with the defines generated from the device tree which place the active partition as area 1 and thus the erase is blocked. Are there any tricks I am missing that might address this mismatch?  | 
    
          
 nrfconnect/sdk-zephyr#2114 should fix the issues you are seeing  | 
    
| 
           Legend, cheers!  | 
    
Fixes #60443