drivers: pinctrl: pfc_rcar: add support of voltage control to pfc driver #66881
Conversation
|
This pull request is a rebase of the following pull request: #60444. The voltage control functionality has been moved from the SOC(s) to the PFC driver. |
zephyrbot
added
platform: Renesas R-Car
zephyrbot
requested review from
SgrrZhf,
carlocaione,
galak,
gmarull,
lorc,
npitre and
povergoing
drivers/pinctrl/Kconfig.rcar
Outdated
There was a problem hiding this comment.
use depends on for single if/endif item. question: what is the reason to guard this feature?
There was a problem hiding this comment.
I believe that adding a PINCTRL_RCAR_PFC check here is unnecessary since the file where the configuration is used is compiled exclusively for PINCTRL_RCAR_PFC. So, I'll remove the checking of PINCTRL_RCAR_PFC from this file.
If you are inquiring about the reason behind the need for the PINCTRL_RCAR_VOLTAGE_CONTROL config, a partial answer can be found here: #60444 (comment). The R-Car PFC driver is utilized for both Gen4 and Gen3 platforms, and currently, the voltage control table has been added only for Gen3.
While it is possible to add a check, such as SOC_SERIES_RCAR_GEN3, to the driver code, but as for me, using an additional config provides a clearer approach.
xakep-amatop
force-pushed
the
rcar-pfc-add-support-of-voltage-control
branch
from
848a076 to
c44e782
Compare
drivers/pinctrl/Kconfig.rcar
Outdated
Add support of voltage control to Renesas PFC driver. Voltage register
mappings have been added to r8a77951 and r8a77961 SoCs.
Allow 'power-source' property for 'renesas,rcar-pfc' node. This property
will be used for configuring IO voltage on appropriate pin. For now it
is possible to have only two voltages: 1.8 and 3.3.
Note: it is possible to change voltage only for SD/MMC pins on r8a77951
and r8a77961 SoCs.
Signed-off-by: Mykola Kvach <[email protected]>
xakep-amatop
force-pushed
the
rcar-pfc-add-support-of-voltage-control
branch
from
c44e782 to
138bf75
Compare
5 participants
Add support of voltage control to Renesas PFC driver. Voltage register mappings have been added to r8a77951 and r8a77961 SoCs.
Allow 'power-source' property for 'renesas,rcar-pfc' node. This property will be used for configuring IO voltage on appropriate pin. For now it is possible to have only two voltages: 1.8 and 3.3.
Note: it is possible to change voltage only for SD/MMC pins on r8a77951 and r8a77961 SoCs.