dts: bindings: Update Nordic owned memory bindings #72273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
dcpleung,
decsny,
galak,
hubertmis,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic,
nashif,
nika-nordic and
nordic-krch
gmarull
reviewed
May 3, 2024
include/zephyr/dt-bindings/reserved-memory/nordic-owned-memory.h
Outdated
Show resolved
Hide resolved
gmarull
reviewed
May 3, 2024
Member
There was a problem hiding this comment.
is it worth deprecating at this stage?
Contributor
Author
There was a problem hiding this comment.
Yes, maybe not for Zephyr but for downstream, deprecation is practical in the short-term.
gmarull
reviewed
May 3, 2024
gmarull
reviewed
May 3, 2024
tests/arch/common/ramfunc/boards/nrf54h20dk_nrf54h20_cpuapp.overlay
Outdated
Show resolved
Hide resolved
57300
force-pushed
the
nordic-owned-memory-update
branch
from
825f86a to
830f1a5
Compare
decsny
previously approved these changes
May 3, 2024
hubertmis
requested changes
May 5, 2024
57300
added a commit
to 57300/sdk-zephyr
that referenced
this pull request
May 6, 2024
Upstream PR: zephyrproject-rtos/zephyr#72273 Access to this region should no longer be requested via UICR, because it will be statically allocated by secure domain firmware. Signed-off-by: Grzegorz Swiderski <[email protected]> (cherry picked from commit d95aa856e98b6561d534cbe36ffc6e87de3deab2)
zephyrbot
added
area: SPI
57300
force-pushed
the
nordic-owned-memory-update
branch
from
6f9ae5e to
16acbad
Compare
57300
force-pushed
the
nordic-owned-memory-update
branch
from
b54ecff to
ab1eabb
Compare
hubertmis
previously approved these changes
Oct 8, 2024
57300
force-pushed
the
nordic-owned-memory-update
branch
from
ab1eabb to
ad5fac9
Compare
57300
added a commit
to 57300/sdk-zephyr
that referenced
this pull request
Oct 8, 2024
Upstream PR: zephyrproject-rtos/zephyr#72273 This concerns both `nordic,owned-memory` and `nordic,owned-partitions`. Introduce a property named `nordic,access`, which is meant to replace the `owner-id` and `perm-*` properties. It allows for describing how multiple domains should access a single memory region, possibly with different permissions per owner, but without having to create more than one DT node for this purpose. This change is also motivated by updated memory protection requirements on the nRF54H20, which mandate that a given memory region must only be reserved by one domain, even if multiple domains can have access to it. This restriction is now described in the binding itself. Signed-off-by: Grzegorz Swiderski <[email protected]> (cherry picked from commit 18d20841a817a126498f5242f67fc6fb1114fd9a)
57300
added a commit
to 57300/sdk-zephyr
that referenced
this pull request
Oct 8, 2024
… bindings Upstream PR: zephyrproject-rtos/zephyr#72273 Apply the following changes to `nrf54h20dk` and `nrf9280pdk`: * Convert `perm-*` properties to the newly introduced `nordic,access`, both in board files and tests. * Redefine shared regions to specify multiple access owners per node, and ensure that each such region is reserved by one domain at a time. `cpuapp_cpurad_ram0x_region` is only enabled by Radiocore, while `cpuapp_cpucell_ram0x_region` is only enabled by Application core. * Divide `shared_ram3x_region` so that each sub-region is owned by a different domain. Their addresses must be rounded down to fit the current UICR format. While at it, increase the `cpurad_dma_region` size from 128 B to 1024 B to better fit the needs of existing tests. Signed-off-by: Grzegorz Swiderski <[email protected]> (cherry picked from commit 16acbadafafd156911b7702178a945bddda9c336)
57300
added a commit
to 57300/sdk-zephyr
that referenced
this pull request
Oct 8, 2024
Upstream PR: zephyrproject-rtos/zephyr#72273 Update the default memory maps for `nrf54h20dk` and `nrf9280pdk` to remove the `shared_ram20_region` and `shared_ram3x_region` nodes, because their child nodes no longer need to be grouped together: * IPC buffers in RAM20 are statically allocated. * DMA buffers in RAM3x have separate access owners. Signed-off-by: Grzegorz Swiderski <[email protected]> (cherry picked from commit ad5fac9cd897fec3e501562edd06179f5b46a8c2)
57300
added a commit
to 57300/sdk-zephyr
that referenced
this pull request
Oct 9, 2024
Upstream PR: zephyrproject-rtos/zephyr#72273 This concerns both `nordic,owned-memory` and `nordic,owned-partitions`. Introduce a property named `nordic,access`, which is meant to replace the `owner-id` and `perm-*` properties. It allows for describing how multiple domains should access a single memory region, possibly with different permissions per owner, but without having to create more than one DT node for this purpose. This change is also motivated by updated memory protection requirements on the nRF54H20, which mandate that a given memory region must only be reserved by one domain, even if multiple domains can have access to it. This restriction is now described in the binding itself. Signed-off-by: Grzegorz Swiderski <[email protected]> (cherry picked from commit 18d20841a817a126498f5242f67fc6fb1114fd9a)
57300
added a commit
to 57300/sdk-zephyr
that referenced
this pull request
Oct 9, 2024
… bindings Upstream PR: zephyrproject-rtos/zephyr#72273 Apply the following changes to `nrf54h20dk` and `nrf9280pdk`: * Convert `perm-*` properties to the newly introduced `nordic,access`, both in board files and tests. * Redefine shared regions to specify multiple access owners per node, and ensure that each such region is reserved by one domain at a time. `cpuapp_cpurad_ram0x_region` is only enabled by Radiocore, while `cpuapp_cpucell_ram0x_region` is only enabled by Application core. * Divide `shared_ram3x_region` so that each sub-region is owned by a different domain. Their addresses must be rounded down to fit the current UICR format. While at it, increase the `cpurad_dma_region` size from 128 B to 1024 B to better fit the needs of existing tests. Signed-off-by: Grzegorz Swiderski <[email protected]> (cherry picked from commit 16acbadafafd156911b7702178a945bddda9c336)
57300
added a commit
to 57300/sdk-zephyr
that referenced
this pull request
Oct 9, 2024
Upstream PR: zephyrproject-rtos/zephyr#72273 Update the default memory maps for `nrf54h20dk` and `nrf9280pdk` to remove the `shared_ram20_region` and `shared_ram3x_region` nodes, because their child nodes no longer need to be grouped together: * IPC buffers in RAM20 are statically allocated. * DMA buffers in RAM3x have separate access owners. Signed-off-by: Grzegorz Swiderski <[email protected]> (cherry picked from commit ad5fac9cd897fec3e501562edd06179f5b46a8c2)
This concerns both `nordic,owned-memory` and `nordic,owned-partitions`. Introduce a property named `nordic,access`, which is meant to replace the `owner-id` and `perm-*` properties. It allows for describing how multiple domains should access a single memory region, possibly with different permissions per owner, but without having to create more than one DT node for this purpose. This change is also motivated by updated memory protection requirements on the nRF54H20, which mandate that a given memory region must only be reserved by one domain, even if multiple domains can have access to it. This restriction is now described in the binding itself. Signed-off-by: Grzegorz Swiderski <[email protected]>
Apply the following changes to `nrf54h20dk` and `nrf9280pdk`: * Convert `perm-*` properties to the newly introduced `nordic,access`, both in board files and tests. * Redefine shared regions to specify multiple access owners per node, and ensure that each such region is reserved by one domain at a time. `cpuapp_cpurad_ram0x_region` is only enabled by Radiocore, while `cpuapp_cpucell_ram0x_region` is only enabled by Application core. * Divide `shared_ram3x_region` so that each sub-region is owned by a different domain. Their addresses must be rounded down to fit the current UICR format. Signed-off-by: Grzegorz Swiderski <[email protected]>
Update the default memory maps for `nrf54h20dk` and `nrf9280pdk` to remove the `shared_ram20_region` and `shared_ram3x_region` nodes, because their child nodes no longer need to be grouped together: * IPC buffers in RAM20 are statically allocated. * DMA buffers in RAM3x have separate access owners. Signed-off-by: Grzegorz Swiderski <[email protected]>
57300
force-pushed
the
nordic-owned-memory-update
branch
from
ad5fac9 to
31587d5
Compare
57300
added a commit
to 57300/sdk-zephyr
that referenced
this pull request
Oct 9, 2024
Upstream PR: zephyrproject-rtos/zephyr#72273 This concerns both `nordic,owned-memory` and `nordic,owned-partitions`. Introduce a property named `nordic,access`, which is meant to replace the `owner-id` and `perm-*` properties. It allows for describing how multiple domains should access a single memory region, possibly with different permissions per owner, but without having to create more than one DT node for this purpose. This change is also motivated by updated memory protection requirements on the nRF54H20, which mandate that a given memory region must only be reserved by one domain, even if multiple domains can have access to it. This restriction is now described in the binding itself. Signed-off-by: Grzegorz Swiderski <[email protected]> (cherry picked from commit a0719f275ec632d74df94f98783a03c441806de2)
57300
added a commit
to 57300/sdk-zephyr
that referenced
this pull request
Oct 9, 2024
… bindings Upstream PR: zephyrproject-rtos/zephyr#72273 Apply the following changes to `nrf54h20dk` and `nrf9280pdk`: * Convert `perm-*` properties to the newly introduced `nordic,access`, both in board files and tests. * Redefine shared regions to specify multiple access owners per node, and ensure that each such region is reserved by one domain at a time. `cpuapp_cpurad_ram0x_region` is only enabled by Radiocore, while `cpuapp_cpucell_ram0x_region` is only enabled by Application core. * Divide `shared_ram3x_region` so that each sub-region is owned by a different domain. Their addresses must be rounded down to fit the current UICR format. Signed-off-by: Grzegorz Swiderski <[email protected]> (cherry picked from commit fa40c98b3d24fe13abd6585c38ce5630a407592f)
57300
added a commit
to 57300/sdk-zephyr
that referenced
this pull request
Oct 9, 2024
Upstream PR: zephyrproject-rtos/zephyr#72273 Update the default memory maps for `nrf54h20dk` and `nrf9280pdk` to remove the `shared_ram20_region` and `shared_ram3x_region` nodes, because their child nodes no longer need to be grouped together: * IPC buffers in RAM20 are statically allocated. * DMA buffers in RAM3x have separate access owners. Signed-off-by: Grzegorz Swiderski <[email protected]> (cherry picked from commit 31587d5a8e0120fbeb7ee9fd4ac00f53b06a78ad)
anangl
approved these changes
Oct 15, 2024
gmarull
approved these changes
Oct 15, 2024
jonathannilsen
pushed a commit
to jonathannilsen/sdk-zephyr
that referenced
this pull request
Oct 16, 2024
Upstream PR: zephyrproject-rtos/zephyr#72273 This concerns both `nordic,owned-memory` and `nordic,owned-partitions`. Introduce a property named `nordic,access`, which is meant to replace the `owner-id` and `perm-*` properties. It allows for describing how multiple domains should access a single memory region, possibly with different permissions per owner, but without having to create more than one DT node for this purpose. This change is also motivated by updated memory protection requirements on the nRF54H20, which mandate that a given memory region must only be reserved by one domain, even if multiple domains can have access to it. This restriction is now described in the binding itself. Signed-off-by: Grzegorz Swiderski <[email protected]> (cherry picked from commit 2b6fe5ea89034f4b1a0222edaa2b1434ac70b78c)
jonathannilsen
pushed a commit
to jonathannilsen/sdk-zephyr
that referenced
this pull request
Oct 16, 2024
… bindings Upstream PR: zephyrproject-rtos/zephyr#72273 Apply the following changes to `nrf54h20dk` and `nrf9280pdk`: * Convert `perm-*` properties to the newly introduced `nordic,access`, both in board files and tests. * Redefine shared regions to specify multiple access owners per node, and ensure that each such region is reserved by one domain at a time. `cpuapp_cpurad_ram0x_region` is only enabled by Radiocore, while `cpuapp_cpucell_ram0x_region` is only enabled by Application core. * Divide `shared_ram3x_region` so that each sub-region is owned by a different domain. Their addresses must be rounded down to fit the current UICR format. Signed-off-by: Grzegorz Swiderski <[email protected]> (cherry picked from commit 049e588ec4fbc22c8eeeeec7fad263dd0105035a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concerns both
nordic,owned-memoryandnordic,owned-partitions.Introduce a property named
nordic,access, which is meant to replacethe
owner-idandperm-*properties. It allows for describing howmultiple domains should access a single memory region, possibly with
different permissions per owner, but without having to create more than
one DT node for this purpose.
This change is also motivated by updated memory protection requirements
on the nRF54H20, which mandate that a given memory region must only be
reserved by one domain, even if multiple domains can have access to it.
This restriction is now described in the binding itself.