west: Regex based version finding in OpenOCD runner #72526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous OpenOCD version finding would fail when additional tokens were prepended to the 'openocd --version' output, as happens with some third- party OpenOCD repackages (xPack for one). Fixes: zephyrproject-rtos#71955 Signed-off-by: Nick Kraus <[email protected]>
MaureenHelm
reviewed
May 30, 2024
Member
MaureenHelm
left a comment
MaureenHelm
left a comment
There was a problem hiding this comment.
@mbolivar-ampere @erwango please take a look
kartben
approved these changes
Jun 12, 2024
Contributor
Author
|
@carlescufi @tejlmand @nordicjm Do these changes look acceptable? I think it would be good to put this issue to rest, I could definitely see new windows users running into it when setting up debugging. |
Member
|
@carlescufi please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous OpenOCD version finding would fail when additional tokens were prepended to the 'openocd --version' output, as happens with some third- party OpenOCD repackages (xPack for one).
Fixes: #71955