-
Notifications
You must be signed in to change notification settings - Fork 8.2k
drivers: input: sbus remote controller support #72628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: input: sbus remote controller support #72628
Conversation
6b0adbc to
70274ef
Compare
Yeah I thought a bit more about it, since you mentioned you are interested in more transports I'm thinking you probably want more flexibility than just "connected/disconnected", I'd imagine stuff like rssi, transmitter battery, identification, stuff like that... I think it's better to go for a custom callback at this stage so you have full flexibility to add what you need, we can always look into unifying things later and keep the driver api for backward compability. |
99c579e to
4261e2f
Compare
|
Thanks for the review and coding tips, wasn't aware of the use of
I'll take look at the callback when I'll find time to implement CRSF which gives way more metadata. |
4261e2f to
00d8ec5
Compare
7c396ec to
eb72f6c
Compare
eb72f6c to
1c1f5f5
Compare
ff91caa to
1c1f5f5
Compare
bperseghetti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this with a few SBUS receivers on different boards and works great, I think only thing left is any other things @fabiobaltieri might desire changed?
485e0f0 to
752b55a
Compare
drivers/input/input_sbus.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unaddressed
752b55a to
48a93ac
Compare
48a93ac to
16a2d78
Compare
Add support SBUS RC controller connected through UART Signed-off-by: Peter van der Perk <[email protected]>
16a2d78 to
95cb82e
Compare
Add support SBUS RC controller connected through UART
@fabiobaltieri Only open point is the discord discourse regarding event id for signalling status.