Skip to content

Conversation

@PetervdPerk-NXP
Copy link
Contributor

Add support SBUS RC controller connected through UART

@fabiobaltieri Only open point is the discord discourse regarding event id for signalling status.

I think an event id corresponding to the devices becoming available/unavailabile is not a bad idea in principle as that's effectively the equivalent of an /dev/input node appearing and disappearing

@PetervdPerk-NXP PetervdPerk-NXP force-pushed the pr-sbus-input-driver branch 3 times, most recently from 6b0adbc to 70274ef Compare May 15, 2024 16:01
@PetervdPerk-NXP PetervdPerk-NXP marked this pull request as ready for review May 15, 2024 16:02
@zephyrbot zephyrbot added area: Input Input Subsystem and Drivers area: Devicetree Binding PR modifies or adds a Device Tree binding platform: NXP NXP labels May 15, 2024
@fabiobaltieri
Copy link
Member

@fabiobaltieri Only open point is the discord discourse regarding event id for signalling status.

Yeah I thought a bit more about it, since you mentioned you are interested in more transports I'm thinking you probably want more flexibility than just "connected/disconnected", I'd imagine stuff like rssi, transmitter battery, identification, stuff like that... I think it's better to go for a custom callback at this stage so you have full flexibility to add what you need, we can always look into unifying things later and keep the driver api for backward compability.

@PetervdPerk-NXP PetervdPerk-NXP force-pushed the pr-sbus-input-driver branch 5 times, most recently from 99c579e to 4261e2f Compare May 15, 2024 19:36
@PetervdPerk-NXP
Copy link
Contributor Author

Thanks for the review and coding tips, wasn't aware of the use of BUILD_ASSERT with DT_PROP very nice feature to statically check dts configs.

I think it's better to go for a custom callback at this stage so you have full flexibility to add what you need, we can always look into unifying things later and keep the driver api for backward compability.

I'll take look at the callback when I'll find time to implement CRSF which gives way more metadata.

@DerekSnell DerekSnell removed their request for review May 15, 2024 20:57
@zephyrbot zephyrbot requested a review from butok May 24, 2024 19:00
@PetervdPerk-NXP PetervdPerk-NXP force-pushed the pr-sbus-input-driver branch 2 times, most recently from 7c396ec to eb72f6c Compare May 24, 2024 19:07
bperseghetti
bperseghetti previously approved these changes May 30, 2024
Copy link
Member

@bperseghetti bperseghetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with a few SBUS receivers on different boards and works great, I think only thing left is any other things @fabiobaltieri might desire changed?

@danieldegrasse danieldegrasse added this to the v3.7.0 milestone Jun 4, 2024
@PetervdPerk-NXP PetervdPerk-NXP force-pushed the pr-sbus-input-driver branch 2 times, most recently from 485e0f0 to 752b55a Compare June 5, 2024 07:13
bperseghetti
bperseghetti previously approved these changes Jun 5, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unaddressed

Add support SBUS RC controller connected through UART

Signed-off-by: Peter van der Perk <[email protected]>
@dleach02 dleach02 merged commit e017006 into zephyrproject-rtos:main Jun 6, 2024
@PetervdPerk-NXP PetervdPerk-NXP deleted the pr-sbus-input-driver branch June 6, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Devicetree Binding PR modifies or adds a Device Tree binding area: Input Input Subsystem and Drivers platform: NXP NXP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants