lib: avoided increments/decrements with side effects #72806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Utilities
area: Formatting Output
area: Base OS
zephyrbot
requested review from
andyross,
dcpleung,
nashif,
nordic-krch and
peter-mitsis
Member
|
@andyross @nordic-krch please take a look |
andyross
previously approved these changes
Jun 14, 2024
Contributor
andyross
left a comment
andyross
left a comment
There was a problem hiding this comment.
OK with the changes, nothing seems awful. I will say that the "*ptr++" pattern is so pervasive in cbprintf in particular that it might be worth abstracting it into something like
#define CONSUME(p) ({ char c = *(p); (p)++; c; })...for clarity, and to avoid all the extra lines. But that's a @nordic-krch decision to make
nashif
previously approved these changes
Jun 14, 2024
nordic-krch
previously approved these changes
Jun 17, 2024
Member
|
@tychofrei02 note a rebase is needed |
- moved ++/-- before or after the value use Signed-off-by: frei tycho <[email protected]>
tychofrei02
dismissed stale reviews from nordic-krch, nashif, and andyross
via
b62dbd7
tychofrei02
force-pushed
the
misra_rule_13_3_auditable_to_main_in_lib/os
branch
from
cf8db95 to
b62dbd7
Compare
nordic-krch
approved these changes
Jun 21, 2024
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoided increments/decrements with side effects.
This corresponds to following coding guideline:
This PR is part of the enhancement issue #48002 which port the coding guideline fixes done by BUGSENG on the https://github.com/zephyrproject-rtos/zephyr/tree/v2.7-auditable-branch back to main
The commit in this PR is a subset of the original auditable-branch commit:
671153b