drivers: i2s_nrfx: Fix division by 0 in divider calculation #72844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
anangl
previously approved these changes
May 16, 2024
barsok
force-pushed
the
bsokol-NCSIDB-1235
branch
from
1ad5170 to
5293f61
Compare
anangl
previously approved these changes
May 16, 2024
masz-nordic
reviewed
May 16, 2024
barsok
force-pushed
the
bsokol-NCSIDB-1235
branch
from
5293f61 to
114cb85
Compare
masz-nordic
previously approved these changes
May 17, 2024
kl-cruz
previously approved these changes
May 21, 2024
anangl
reviewed
May 23, 2024
drivers/i2s/i2s_nrfx.c
Outdated
Member
There was a problem hiding this comment.
Since this constant value is only used locally, I'd rather use:
Suggested change
| #define MCKCONST 1048576 | |
| enum { MCKCONST = 1048576 }; |
#define looks a bit weird with such indentation (which is also off by one currently).
Skip cases which would result in division by 0 in clock calculation Signed-off-by: Bartosz Sokolski <[email protected]>
barsok
force-pushed
the
bsokol-NCSIDB-1235
branch
from
114cb85 to
81f72a8
Compare
anangl
approved these changes
Jun 25, 2024
jaz1-nordic
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip cases which would result in division by 0 in clock calculation
Fixes #70316