hostap: support enterprise and DPP #73249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengming-ye
force-pushed
the
feature/hostap_crypto_mbedtls
branch
from
1ab6b9d to
cdb34b0
Compare
fengming-ye
force-pushed
the
feature/hostap_crypto_mbedtls
branch
3 times, most recently
from
fc9091b to
4631607
Compare
fengming-ye
force-pushed
the
feature/hostap_crypto_mbedtls
branch
from
4631607 to
cd9a397
Compare
krish2718
reviewed
May 29, 2024
Contributor
krish2718
left a comment
krish2718
left a comment
There was a problem hiding this comment.
From a quick look changes LGTM, but can you please divide in to smaller commits with appropriate commit logs?
E.g.
- NO_PBKDF2
- Removing blobs and why
- Adding CRC32
- Moving existing crypto
- Adding DPP
- Adding ALT crypto
...
fengming-ye
force-pushed
the
feature/hostap_crypto_mbedtls
branch
from
cd9a397 to
e2450e2
Compare
Contributor
Author
updated pls check |
Contributor
Author
|
There might be a CI issue in compliance check fail warning: undefined symbol MBEDTLS_MAC_CMAC_ENABLED: But MBEDTLS_MAC_CMAC_ENABLED is defined in modules/mbedtls/Kconfig.tls-generic like other symbols. |
fengming-ye
force-pushed
the
feature/hostap_crypto_mbedtls
branch
from
e2450e2 to
5dc42d5
Compare
Member
@fengming-ye, this changed in a PR that merged yesterday (things move fast at times) [#73267]. All the MBED_MAC_ENABLED have changed to just MBED |
dleach02
reviewed
May 30, 2024
modules/hostap/Kconfig
Outdated
Add kconfig CONFIG_WIFI_NM_WPA_SUPPLICANT_CRYPTO_ALT to get more mbedtls functionality for enterprise and DPP. Split cmake sources related to hostap SME and crypto backend. Default backend CONFIG_WIFI_NM_WPA_SUPPLICANT_CRYPTO use internal crypto and some mbedtls apis. Backend CONFIG_WIFI_NM_WPA_SUPPLICANT_CRYPTO_ALT use most mbedtls apis and PSA apis, except some apis no longer supported in mbedtls 3.x, or called in the middle of hostap and mbedtls. Signed-off-by: Fengming Ye <[email protected]>
Add Platform Secure Architecture support support to use HW acceleration, which needs to be called under PSA driver wrapper in mbedtls 3.x. Signed-off-by: Fengming Ye <[email protected]>
Add kconfig and cmake to support DPP (Easy Connect). Signed-off-by: Fengming Ye <[email protected]>
Remove CONFIG_NO_PBKDF2 and CONFIG_NO_CONFIG_BLOBS definition and let them be decided in kconfig. CONFIG_NO_PBKDF2 is default y when crypto backend is WIFI_NM_WPA_SUPPLICANT_CRYPTO_NONE. CONFIG_NO_CONFIG_BLOBS is default y when both DPP and enterprise disable. Signed-off-by: Fengming Ye <[email protected]>
Add enterprise needed source files. Signed-off-by: Fengming Ye <[email protected]>
Add MBEDTLS_NIST_KW_C, MBEDTLS_DHM_C and X509 CRL, CSR options. Signed-off-by: Fengming Ye <[email protected]>
fengming-ye
force-pushed
the
feature/hostap_crypto_mbedtls
branch
from
5dc42d5 to
a794aa6
Compare
Contributor
Author
|
Hi @jukkar @krish2718 Hi @ceolin @d3zd3z @ithinuel Thanks. |
dleach02
approved these changes
Jun 4, 2024
krish2718
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change cmake and kconfig for enterprise and DPP support.