-
Notifications
You must be signed in to change notification settings - Fork 8.2k
drivers: rtc: Add Micro Crystal RV-8263-C8 driver #73385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
21edc49 to
1db2263
Compare
e287368 to
5166977
Compare
e9bdfc9 to
53637d2
Compare
decsny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments apply to all the properties in the DT binding
3ecde5c to
b9c31c5
Compare
After save it, to modify rtc_rv8263.c to merge the changes of the above 3 picks. |
jakubtopic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The driver looks really good :) Some minor suggestions...
d3dd5e8 to
1babe06
Compare
I´ve added the points from @jakubtopic. The unit test is successful so it should be fine. I found a missing option for clkout 1024 Hz and fixed it too: |
Remove redundant code Signed-off-by: Daniel Kampert <[email protected]>
|
I changed the line 333 to |
Description
This PR adds support for Micro Crystal RV-8263-C8 RTC connected to the I2C bus.
Supported functions
Tested
Closes #73384