sd: sd_ops: fix DISK_IOCTL_CTRL_SYNC return code #73428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SD IOCTL handling for DISK_IOCTL_CTRL_SYNC was falling through to the default return statement, and returning an error when disk sync succeeded. Fix this issue by properly breaking in IOCTL handler. Signed-off-by: Daniel DeGrasse <[email protected]>
danieldegrasse
added
the
Trivial
de-nordic
approved these changes
May 28, 2024
decsny
approved these changes
May 28, 2024
Member
|
Does seem odd that this wasn't showing up on any of the tests but our super simple write to SD application always had this issue. |
bperseghetti
approved these changes
May 28, 2024
Contributor
Author
Agree, the changes in #73437 should make sure this is exposed in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SD IOCTL handling for DISK_IOCTL_CTRL_SYNC was falling through to the default return statement, and returning an error when disk sync succeeded. Fix this issue by properly breaking in IOCTL handler.