llext: add pre_located test
#73479
Merged
llext: add pre_located test
#73479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@pillo79 thanks, good to have a test for this! Looks like you've forgotten the .c file https://github.com/zephyrproject-rtos/zephyr/actions/runs/9289449787/job/25564543119?pr=73479#step:12:336 BTW, since this isn't actually executing, maybe an existing llext test file could be reused. But I tend to agree, that having a separate .c is cleaner, it should be really small too. |
Contributor
Author
|
A perfect use case for the "facepalm" emoticon as a reaction... 😅 |
pillo79
force-pushed
the
reloc
branch
2 times, most recently
from
dfb75ff to
bad3c04
Compare
Contributor
Author
|
Rebased to fix CI issues with Apollo and included the latest revision of #72479. |
This test checks that the pre_located feature works as expected. It creates a new extension that is manually relocated to a specific address via the add_llext_command() CMake function invoking a custom linker command. The test then loads the extension setting the pre_located option and checks that the symbol is resolved properly. Signed-off-by: Luca Burelli <[email protected]>
pillo79
changed the title
pre_located testpre_located test
teburd
approved these changes
May 30, 2024
lyakh
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a test for the
pre_locatedfeature added in #72479, by crafting a special extension that is not supposed to be executed but contains a symbol whose address is manually placed via a custom link step.This also replaces the current dummy
add_llext_command()step with an actual use case.