Skip to content

Conversation

@miggazElquez
Copy link
Contributor

This PR add a driver for the magnetometer of the lsm9ds1 sensor (https://www.st.com/en/mems-and-sensors/lsm9ds1.html).

The four first commits (3a3b731f503d719a63df5cb28ce2c655be853d5f..e64fe2cbea0d985e8064de17b67bcc23301b6a2b) are part of #73141.

@miggazElquez miggazElquez requested a review from avisconti as a code owner May 30, 2024 14:57
@zephyrbot zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensors Sensors area: Samples Samples labels May 30, 2024
@decsny decsny removed their request for review May 30, 2024 15:23
@ubieda
Copy link
Member

ubieda commented May 30, 2024

@miggazElquez just curious, why filing two separate PRs for the same driver?

@miggazElquez
Copy link
Contributor Author

@miggazElquez just curious, why filing two separate PRs for the same driver?

It was asked by @jeppenodgaard, so I did as asked. And the two driver are independent, even if it's the same sensor, from a logical point of view they are totally different (different adress on the bus, different registers...) so it kind of make sense.

@miggazElquez miggazElquez changed the title Lsm9ds1 mag driver drivers: Lsm9ds1 mag driver May 31, 2024
@miggazElquez miggazElquez force-pushed the lsm9ds1_mag_driver branch 3 times, most recently from b024f13 to 0a939d7 Compare June 12, 2024 11:58
@zephyrbot zephyrbot requested a review from jeppenodgaard June 12, 2024 11:59
@miggazElquez miggazElquez force-pushed the lsm9ds1_mag_driver branch 3 times, most recently from 6ba3f3d to 9378ce9 Compare June 20, 2024 10:00
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs to be rebased.

@avisconti please take a look

@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Oct 20, 2024
@github-actions github-actions bot closed this Nov 3, 2024
@miggazElquez miggazElquez deleted the lsm9ds1_mag_driver branch June 13, 2025 13:41
@miggazElquez miggazElquez restored the lsm9ds1_mag_driver branch June 13, 2025 13:41
@nordicjm nordicjm reopened this Jun 16, 2025
@miggazElquez
Copy link
Contributor Author

I had forgotten this PR, I rebased on main and modified the code to use DEVICE_API.

@miggazElquez
Copy link
Contributor Author

Rebased on main to fix merge conflict

This commit adds a description for the magnetometer part of the lsm9ds1
sensor.

Signed-off-by: Miguel Gazquez <[email protected]>
This driver supports the magnetometer in the ST lsm9ds1 sensor, on the
I2C bus.
This driver does not support the triggers.
This driver use the stmemsc HAL.

link: https://www.st.com/resource/en/datasheet/lsm9ds1.pdf

Signed-off-by: Miguel Gazquez <[email protected]>
…e tree

Describe the magnetometer part of the lsm9ds1 sensor, available in the
Arduino Nano 33 BLE through I2C.

Signed-off-by: Miguel Gazquez <[email protected]>
@sonarqubecloud
Copy link

@miggazElquez
Copy link
Contributor Author

@MaureenHelm @avisconti Could you please take a look ?

@danieldegrasse danieldegrasse merged commit 68795fc into zephyrproject-rtos:main Jun 26, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Devicetree Binding PR modifies or adds a Device Tree binding area: Samples Samples area: Sensors Sensors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants