-
Notifications
You must be signed in to change notification settings - Fork 8.3k
doc: project roles: reviewer and assignee clarification #73691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
425f6e7 to
3a27e3a
Compare
henrikbrixandersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds reasonable and hopefully matches our already existing practice.
|
@dleach02 - there was an issue where a reviewer closed the PR of a new contributor. This PR highlights that reviewers shouldn't do this. |
Clarification of reviewer expectations and role. Emphasis on clarifying when a PR can be closed. Highlighting reviewers and assignee objective to guide PR to a mergeable state, if possible. Signed-off-by: David Leach <[email protected]>
4fdbe0d
Clarification of reviewer expectations and role. Emphasis on clarifying when a PR can be closed.
Highlighting reviewers and assignee objective to guide PR to a mergeable state, if possible.