Skip to content

Add adc support for Beagleconnect Freedom #73724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2024
Merged

Add adc support for Beagleconnect Freedom #73724

merged 2 commits into from
Jul 29, 2024

Conversation

@Ayush1325
Copy link
Member

@Ayush1325 Ayush1325 commented Jun 4, 2024

@zephyrbot zephyrbot added area: Samples Samples area: ADC Analog-to-Digital Converter (ADC) labels Jun 4, 2024
@zephyrbot zephyrbot requested review from anangl, decsny, kartben and nashif June 4, 2024 13:19
@zephyrbot
Copy link

zephyrbot commented Jun 4, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_ti zephyrproject-rtos/hal_ti@b85f86e zephyrproject-rtos/hal_ti@2e7b95a (master) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@vaishnavachath vaishnavachath self-requested a review June 4, 2024 13:22
vaishnavachath
vaishnavachath previously approved these changes Jun 4, 2024
View reviewed changes
@Ayush1325
Copy link
Member Author

Ayush1325 commented Jun 4, 2024

Not sure about the CI fail

@decsny decsny removed their request for review June 5, 2024 14:45
Ayush1325 added a commit to Ayush1325/gsoc-2022-arduino-core that referenced this pull request Jun 6, 2024
@Ayush1325
beagleconnect_freedom: Add adc support
4a36520 
- Waiting for zephyrproject-rtos/zephyr#73724
- Tested analog_input sample

Signed-off-by: Ayush Singh <[email protected]>
@Ayush1325 Ayush1325 mentioned this pull request Jun 6, 2024
Merged
@jadonk
Copy link
Member

jadonk commented Jun 6, 2024

Not sure about the CI fail

What seems to have added a similar issue:
#71444
35fc91c

What seems to have fixed it:
coreboot/zephyr-cros@0bcdc2b

Do you have that commit in your tree?

jadonk
jadonk requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@jadonk jadonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you:

@Ayush1325 Ayush1325 force-pushed the bcf-adc branch 3 times, most recently from eabef0c to f9ba273 Compare June 13, 2024 18:28
Ayush1325 added a commit to Ayush1325/gsoc-2022-arduino-core that referenced this pull request Jun 14, 2024
@Ayush1325
beagleconnect_freedom: Add adc support
4e66fb3 
- Waiting for zephyrproject-rtos/zephyr#73724
- Tested analog_input sample

Signed-off-by: Ayush Singh <[email protected]>
Ayush1325 added a commit to Ayush1325/gsoc-2022-arduino-core that referenced this pull request Jun 14, 2024
@Ayush1325
beagleconnect_freedom: Add adc support
697a5dd 
- Waiting for zephyrproject-rtos/zephyr#73724
- Tested analog_input sample

Signed-off-by: Ayush Singh <[email protected]>
Ayush1325 added a commit to Ayush1325/gsoc-2022-arduino-core that referenced this pull request Jun 14, 2024
@Ayush1325
beagleconnect_freedom: Add adc support
a66aa2e 
- Waiting for zephyrproject-rtos/zephyr#73724
- Tested analog_input sample

Signed-off-by: Ayush Singh <[email protected]>
jadonk
jadonk reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@jadonk jadonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share the output of running the sample? It would be nice if the sample clarified that it was sampling MB1 AN.

@Ayush1325
Copy link
Member Author

Ayush1325 commented Jun 26, 2024 •
edited
Loading

Screenshot_20240626_192917

Here is the output. @jadonk do note that this sample is for driver developers and not users (samples/drivers). I do not think any changes to the output of this sample should be a part of this PR. For a driver sample, it is more important to have channel in output rather than the Pin.

@jadonk
Copy link
Member

jadonk commented Jun 26, 2024

Here is the output. @jadonk do note that this sample is for driver developers and not users (samples/drivers). I do not think any changes to the output of this sample should be a part of this PR. For a driver sample, it is more important to have channel in output rather than the Pin.

Well, there are different classes of developers. I believe developers don't want to dive into the schematic or soc details and want to jump directly to the features exposed on the board. I'm not looking to update the sample itself, as it reflects a certain perspective on usage I'd want to preserve. I just note that in one example output, "ADC_0" was presented and I think presenting "MB1_AN" would be nice. I'm not sure if this is possible.

BTW, 3.6V seems a bit high. What are you connecting? Is the ADC value accurate?

jadonk
jadonk reviewed Jun 26, 2024
View reviewed changes
@Ayush1325
Copy link
Member Author

Ayush1325 commented Jun 26, 2024 •
edited
Loading

Well, there are different classes of developers. I believe developers don't want to dive into the schematic or soc details and want to jump directly to the features exposed on the board. I'm not looking to update the sample itself, as it reflects a certain perspective on usage I'd want to preserve. I just note that in one example output, "ADC_0" was presented and I think presenting "MB1_AN" would be nice. I'm not sure if this is possible.

It is possible, but changes will be required to the sample itself. Thus it should not be done in this PR.

BTW, 3.6V seems a bit high. What are you connecting? Is the ADC value accurate?

It's an LDR at 5v. Reads around 100 when exposed to direct light. It can be scaled using Potentiometer.

@Ayush1325 Ayush1325 requested a review from jadonk July 10, 2024 09:58
@Ayush1325
Copy link
Member Author

Ayush1325 commented Jul 10, 2024

Cc: @vaishnavachath @kartben @cfriedt @jadonk @nashif @anangl

Ayush1325 and others added 2 commits July 10, 2024 16:32
@Ayush1325
manifest: Update hal_ti revision
c863d5b 
- Fixes zephyrproject-rtos#73468

Signed-off-by: Ayush Singh <[email protected]>
@Ayush1325
samples: drivers: adc: Add beagleconnect freedom overlay
4dedeab 
- Add support for beagleconnect freedom

Signed-off-by: Ayush Singh <[email protected]>
jadonk
jadonk approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@jadonk jadonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cfriedt
cfriedt approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :-)

@nashif nashif added this to the v4.0.0 milestone Jul 12, 2024
Ayush1325 added a commit to Ayush1325/gsoc-2022-arduino-core that referenced this pull request Jul 15, 2024
@Ayush1325
beagleconnect_freedom: Add adc support
6292d54 
- Waiting for zephyrproject-rtos/zephyr#73724
- Tested analog_input sample

Signed-off-by: Ayush Singh <[email protected]>
@aescolar aescolar merged commit 99d6a82 into zephyrproject-rtos:main Jul 29, 2024
@Ayush1325 Ayush1325 deleted the bcf-adc branch July 29, 2024 12:53
Ayush1325 added a commit to Ayush1325/gsoc-2022-arduino-core that referenced this pull request Jul 31, 2024
@Ayush1325
beagleconnect_freedom: Add adc support
2f41ac9 
- Waiting for zephyrproject-rtos/zephyr#73724
- Tested analog_input sample

Signed-off-by: Ayush Singh <[email protected]>
@vaishnavachath vaishnavachath mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jadonk jadonk jadonk approved these changes

@cfriedt cfriedt cfriedt approved these changes

@anangl anangl anangl approved these changes

@kartben kartben Awaiting requested review from kartben

@nashif nashif Awaiting requested review from nashif

@vaishnavachath vaishnavachath Awaiting requested review from vaishnavachath

Assignees

@anangl anangl

Labels

area: ADC Analog-to-Digital Converter (ADC) area: Samples Samples manifest manifest-hal_ti

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

adc_cc13xx_cc26xx fails to build for beagleconnect freedom

8 participants

@Ayush1325 @zephyrbot @jadonk @cfriedt @anangl @vaishnavachath @nashif @aescolar